Page MenuHomePhabricator

Fix an issue where "bin/differential migrate-hunk" could decompress data
ClosedPublic

Authored by epriestley on Sep 18 2017, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 6:55 PM
Unknown Object (File)
Thu, Nov 21, 3:44 AM
Unknown Object (File)
Sun, Nov 17, 8:03 AM
Unknown Object (File)
Sat, Oct 26, 11:05 PM
Unknown Object (File)
Oct 20 2024, 6:21 AM
Unknown Object (File)
Oct 17 2024, 6:29 AM
Unknown Object (File)
Sep 9 2024, 1:12 PM
Unknown Object (File)
Sep 3 2024, 9:34 PM
Subscribers
None

Details

Summary

Fixes T12986. I caught this bug in the changes from D18584: when we moved a large hunk to file storage, we would decompress it but keep the "deflated" flag. This could cause confusion when loading it later. I missed this in testing since I wasn't exhaustive enough in checking hunks and didn't run into a compressed one.

Instead of compressing on save(), compress during the normal workflow.

We currently never advise users to run this workflow so I didn't bother trying to clean up possible existing migrations.

Test Plan
  • Ran bin/differential migrate-hunk on compressed hunks, moving them to and from file storage. Saw them work correctly and remain compressed.
  • Created new small (uncompressed) and large (compressed) hunks, verified they work properly and get compressed (if applicable).
  • Used bin/cache purge --caches changeset to clear changeset caches and make sure the actual table was being hit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable