Differential D18614
Update major RefCursor callsites to work properly with RefPosition Authored by epriestley on Sep 15 2017, 4:20 PM. Tags None Referenced Files
Subscribers None
Details Ref T11823. This is the meaty part of the change, and updates RefEngine to use separate RefCursor (for names) and RefPosition (for actual commit positions) tables. I'll hold this whole series until after the release cut so it has some time to bake on secure to look for issues. It's also not a huge problem if there are bugs here since these tables are just caches anyway, although they do feed into some other things, and obviously it's never good to have bugs.
Diff Detail
Event TimelineComment Actions I only vaguely understand what this accomplishes, but I trust that we'll break secure before it goes out everywhere. Comment Actions Yeah, I think it will be reasonably clear on this install (and reasonably easy to investigate and recover from) if I did botch something here. Since the input is basically "any arbitrary repository state, plus any arbitrary cached older version of that repository state" it's pretty difficult to have much confidence that I truly tested it exhaustively, but my gut is that it's at least mostly on firm ground. |