Page MenuHomePhabricator

Add a RefPosition table to hold branch/tag positions once the RefCursor table is split
ClosedPublic

Authored by epriestley on Sep 14 2017, 12:13 PM.
Tags
None
Referenced Files
F14077693: D18602.diff
Fri, Nov 22, 12:55 AM
Unknown Object (File)
Mon, Nov 18, 2:47 PM
Unknown Object (File)
Wed, Nov 13, 11:46 PM
Unknown Object (File)
Sun, Nov 10, 7:16 AM
Unknown Object (File)
Thu, Nov 7, 6:56 PM
Unknown Object (File)
Wed, Nov 6, 5:06 AM
Unknown Object (File)
Thu, Oct 31, 6:45 AM
Unknown Object (File)
Oct 16 2024, 7:04 PM
Subscribers
None

Details

Summary

Ref T11823. Currently, we have a "RefCursor" table which stores rows like <branch or tag name, commit it is pointing at> with some more data.

Because Mercurial can have a single branch pointing at several different places, this table must allow multiple rows with the same branch or tag name.

Among other things, this means there isn't a single PHID which can be used to identify a branch name in a stable way. However, we have several UIs where we want to be able to do this.

Some specific examples where we run into trouble: in Mercurial, if there are 5 heads for "default", that means there are 5 phids. And currently, if someone deletes a branch, we lose the PHID for it. Instead, we'd rather retain it so the whole world doesn't break if you accidentally delete a branch and then fix it a little later.

(I'll likely hold this until the rest of the logic is fleshed out a little more in followup changes.)

Test Plan

Ran bin/storage upgrade, saw the table get created without warnings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable