Page MenuHomePhabricator

Stop the bleeding caused by attaching enormous patches to revision mail
ClosedPublic

Authored by epriestley on Sep 12 2017, 10:43 PM.
Tags
None
Referenced Files
F18832542: D18598.id44662.diff
Sat, Oct 25, 10:06 PM
F18832541: D18598.id44657.diff
Sat, Oct 25, 10:06 PM
F18832540: D18598.id44656.diff
Sat, Oct 25, 10:06 PM
F18832539: D18598.id.diff
Sat, Oct 25, 10:06 PM
F18831548: D18598.diff
Sat, Oct 25, 1:42 PM
F18821495: D18598.id44657.diff
Oct 22 2025, 11:44 PM
F18815860: D18598.id.diff
Oct 21 2025, 4:01 AM
F18807422: D18598.diff
Oct 19 2025, 1:35 AM
Subscribers
None

Details

Summary

Ref T12033. This is a very narrow fix for this issue, but it should fix the major error: don't attach patches if they're bigger than the mail body limit (by default, 512KB).

Specifically, the logs from an install in T12033 show a 112MB patch being attached, and that's the biggest practical problem here.

I'll follow up on the tasks with more nuanced future work.

Test Plan

Enabled differential.attach-patches, saw a patch attached to email. Set the byte limit very low, saw patches get thrown away.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable