Page MenuHomePhabricator

Stop the bleeding caused by attaching enormous patches to revision mail
ClosedPublic

Authored by epriestley on Sep 12 2017, 10:43 PM.
Tags
None
Referenced Files
F14076989: D18598.diff
Thu, Nov 21, 8:51 PM
Unknown Object (File)
Mon, Nov 18, 12:33 PM
Unknown Object (File)
Wed, Nov 13, 7:12 PM
Unknown Object (File)
Tue, Nov 12, 6:54 AM
Unknown Object (File)
Sun, Nov 10, 11:51 AM
Unknown Object (File)
Wed, Nov 6, 9:45 AM
Unknown Object (File)
Thu, Oct 24, 6:09 AM
Unknown Object (File)
Oct 22 2024, 7:50 AM
Subscribers
None

Details

Summary

Ref T12033. This is a very narrow fix for this issue, but it should fix the major error: don't attach patches if they're bigger than the mail body limit (by default, 512KB).

Specifically, the logs from an install in T12033 show a 112MB patch being attached, and that's the biggest practical problem here.

I'll follow up on the tasks with more nuanced future work.

Test Plan

Enabled differential.attach-patches, saw a patch attached to email. Set the byte limit very low, saw patches get thrown away.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable