Page MenuHomePhabricator

Stop the bleeding caused by attaching enormous patches to revision mail
ClosedPublic

Authored by epriestley on Sep 12 2017, 10:43 PM.
Tags
None
Referenced Files
F18821495: D18598.id44657.diff
Wed, Oct 22, 11:44 PM
F18815860: D18598.id.diff
Tue, Oct 21, 4:01 AM
F18807422: D18598.diff
Sun, Oct 19, 1:35 AM
F18803065: D18598.id44656.diff
Fri, Oct 17, 9:28 PM
F18784717: D18598.id44662.diff
Mon, Oct 13, 2:53 PM
F18684593: D18598.id.diff
Fri, Sep 26, 9:46 AM
F18509109: D18598.id.diff
Sep 5 2025, 3:13 AM
F18501618: D18598.diff
Sep 4 2025, 9:51 PM
Subscribers
None

Details

Summary

Ref T12033. This is a very narrow fix for this issue, but it should fix the major error: don't attach patches if they're bigger than the mail body limit (by default, 512KB).

Specifically, the logs from an install in T12033 show a 112MB patch being attached, and that's the biggest practical problem here.

I'll follow up on the tasks with more nuanced future work.

Test Plan

Enabled differential.attach-patches, saw a patch attached to email. Set the byte limit very low, saw patches get thrown away.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable