Page MenuHomePhabricator

Stop the bleeding caused by attaching enormous patches to revision mail
ClosedPublic

Authored by epriestley on Sep 12 2017, 10:43 PM.
Tags
None
Referenced Files
F15493110: D18598.id44657.diff
Sat, Apr 12, 9:33 PM
F15490746: D18598.id44662.diff
Fri, Apr 11, 8:16 PM
F15490642: D18598.id44656.diff
Fri, Apr 11, 7:16 PM
F15488602: D18598.id.diff
Thu, Apr 10, 11:54 PM
F15482026: D18598.diff
Wed, Apr 9, 2:07 AM
F15471558: D18598.id44656.diff
Sat, Apr 5, 5:56 AM
F15469631: D18598.id44662.diff
Fri, Apr 4, 3:08 PM
F15466359: D18598.id44656.diff
Thu, Apr 3, 4:40 AM
Subscribers
None

Details

Summary

Ref T12033. This is a very narrow fix for this issue, but it should fix the major error: don't attach patches if they're bigger than the mail body limit (by default, 512KB).

Specifically, the logs from an install in T12033 show a 112MB patch being attached, and that's the biggest practical problem here.

I'll follow up on the tasks with more nuanced future work.

Test Plan

Enabled differential.attach-patches, saw a patch attached to email. Set the byte limit very low, saw patches get thrown away.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable