Page MenuHomePhabricator

Stop the bleeding caused by attaching enormous patches to revision mail
ClosedPublic

Authored by epriestley on Sep 12 2017, 10:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:11 AM
Unknown Object (File)
Sun, Apr 7, 4:08 AM
Unknown Object (File)
Fri, Apr 5, 3:35 AM
Unknown Object (File)
Thu, Mar 28, 4:06 AM
Unknown Object (File)
Tue, Mar 26, 8:28 PM
Unknown Object (File)
Wed, Mar 20, 6:40 AM
Unknown Object (File)
Wed, Mar 20, 6:40 AM
Unknown Object (File)
Wed, Mar 20, 6:40 AM
Subscribers
None

Details

Summary

Ref T12033. This is a very narrow fix for this issue, but it should fix the major error: don't attach patches if they're bigger than the mail body limit (by default, 512KB).

Specifically, the logs from an install in T12033 show a 112MB patch being attached, and that's the biggest practical problem here.

I'll follow up on the tasks with more nuanced future work.

Test Plan

Enabled differential.attach-patches, saw a patch attached to email. Set the byte limit very low, saw patches get thrown away.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable