Page MenuHomePhabricator

Stop the bleeding caused by attaching enormous patches to revision mail
ClosedPublic

Authored by epriestley on Sep 12 2017, 10:43 PM.
Tags
None
Referenced Files
F15434813: D18598.id44657.diff
Tue, Mar 25, 5:36 AM
F15433648: D18598.id44657.diff
Tue, Mar 25, 12:14 AM
F15430232: D18598.id44657.diff
Mon, Mar 24, 6:37 AM
F15326093: D18598.diff
Fri, Mar 7, 3:13 AM
F15292793: D18598.diff
Wed, Mar 5, 2:56 AM
Unknown Object (File)
Feb 23 2025, 1:45 AM
Unknown Object (File)
Feb 21 2025, 4:14 AM
Unknown Object (File)
Feb 18 2025, 6:54 AM
Subscribers
None

Details

Summary

Ref T12033. This is a very narrow fix for this issue, but it should fix the major error: don't attach patches if they're bigger than the mail body limit (by default, 512KB).

Specifically, the logs from an install in T12033 show a 112MB patch being attached, and that's the biggest practical problem here.

I'll follow up on the tasks with more nuanced future work.

Test Plan

Enabled differential.attach-patches, saw a patch attached to email. Set the byte limit very low, saw patches get thrown away.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable