Page MenuHomePhabricator

Stop the bleeding caused by attaching enormous patches to revision mail
ClosedPublic

Authored by epriestley on Sep 12 2017, 10:43 PM.
Tags
None
Referenced Files
F14755449: D18598.id44662.diff
Tue, Jan 21, 4:02 PM
Unknown Object (File)
Tue, Jan 21, 12:36 PM
Unknown Object (File)
Tue, Jan 21, 10:23 AM
Unknown Object (File)
Fri, Jan 17, 10:22 PM
Unknown Object (File)
Fri, Jan 17, 2:47 PM
Unknown Object (File)
Tue, Dec 31, 4:23 AM
Unknown Object (File)
Thu, Dec 26, 4:22 PM
Unknown Object (File)
Dec 21 2024, 1:54 PM
Subscribers
None

Details

Summary

Ref T12033. This is a very narrow fix for this issue, but it should fix the major error: don't attach patches if they're bigger than the mail body limit (by default, 512KB).

Specifically, the logs from an install in T12033 show a 112MB patch being attached, and that's the biggest practical problem here.

I'll follow up on the tasks with more nuanced future work.

Test Plan

Enabled differential.attach-patches, saw a patch attached to email. Set the byte limit very low, saw patches get thrown away.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable