Page MenuHomePhabricator
Differential D18594

Issue upgrade guidance to rebuild indexes for the Ferret engine
ClosedPublic
Actions

Authored by epriestley on Sep 12 2017, 3:28 PM.
Tags
None
Referenced Files
F13090000: D18594.diff
Thu, Apr 25, 2:09 AM
F13081033: D18594.id44655.diff
Wed, Apr 24, 1:13 PM
F13081032: D18594.id44645.diff
Wed, Apr 24, 1:13 PM
F13081029: D18594.id.diff
Wed, Apr 24, 1:12 PM
F13080997: D18594.diff
Wed, Apr 24, 12:44 PM
Unknown Object (File)
Sun, Apr 21, 3:49 PM
Unknown Object (File)
Fri, Apr 19, 2:42 AM
Unknown Object (File)
Fri, Apr 19, 2:42 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size
Commits
rP124e580f6ec7: Issue upgrade guidance to rebuild indexes for the Ferret engine
Summary

Ref T12819. This is shipping, so issue upgrade guidance to instruct installs to rebuild the index.

Also generate a new quickstart.sql since we haven't regenerated in a bit and there's been a large amount of table churn fairly recently.

Test Plan

Ran bin/storage upgrade, saw guidance notification in UI.

Diff Detail

Repository
rP Phabricator
Branch
ferret9
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningresources/sql/quickstart.sql:118TXT3Line Too Long
Warningresources/sql/quickstart.sql:119TXT3Line Too Long
Warningresources/sql/quickstart.sql:120TXT3Line Too Long
Warningresources/sql/quickstart.sql:745TXT3Line Too Long
Warningresources/sql/quickstart.sql:746TXT3Line Too Long
Warningresources/sql/quickstart.sql:747TXT3Line Too Long
Warningresources/sql/quickstart.sql:1885TXT3Line Too Long
Warningresources/sql/quickstart.sql:1886TXT3Line Too Long
Warningresources/sql/quickstart.sql:1887TXT3Line Too Long
Warningresources/sql/quickstart.sql:1957TXT3Line Too Long
Warningresources/sql/quickstart.sql:2239TXT3Line Too Long
Warningresources/sql/quickstart.sql:2273TXT3Line Too Long
Warningresources/sql/quickstart.sql:2274TXT3Line Too Long
Warningresources/sql/quickstart.sql:2275TXT3Line Too Long
Warningresources/sql/quickstart.sql:2474TXT3Line Too Long
Warningresources/sql/quickstart.sql:2475TXT3Line Too Long
Warningresources/sql/quickstart.sql:2476TXT3Line Too Long
Warningresources/sql/quickstart.sql:2552TXT3Line Too Long
Warningresources/sql/quickstart.sql:2553TXT3Line Too Long
Warningresources/sql/quickstart.sql:2554TXT3Line Too Long
Warningresources/sql/quickstart.sql:2684TXT3Line Too Long
Warningresources/sql/quickstart.sql:2685TXT3Line Too Long
Warningresources/sql/quickstart.sql:2686TXT3Line Too Long
Warningresources/sql/quickstart.sql:2906TXT3Line Too Long
Warningresources/sql/quickstart.sql:2907TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 18427
Build 24813: Run Core Tests
Build 24812: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 12 2017, 3:28 PM
chad accepted this revision.Sep 12 2017, 5:59 PM
This revision is now accepted and ready to land.Sep 12 2017, 5:59 PM
Closed by commit rP124e580f6ec7: Issue upgrade guidance to rebuild indexes for the Ferret engine (authored by epriestley). · Explain WhySep 12 2017, 7:21 PM
This revision was automatically updated to reflect the committed changes.
epriestley added inline comments.Sep 12 2017, 7:23 PM
resources/sql/quickstart.sql
3480

Oh, these are actually wrong for quickstart (storage upgrade adjusts the table engine later if possible). These tables will also get killed off soon, hopefully.

epriestley mentioned this in rP6cedd4a95cfc: Revert quickstart for tables with native FULLTEXT indexes to MyISAM.Sep 12 2017, 7:24 PM
epriestley mentioned this in D20480: Update Quickstart SQL.Apr 25 2019, 10:54 PM
epriestley mentioned this in rP5462a52b8a0c: Update Quickstart SQL.Apr 30 2019, 3:19 PM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
19 lines
552 lines

Diff 44645

View Options

resources/sql/autopatches/20170912.ferret.01.activity.php

Loading...
View Options

resources/sql/quickstart.sql

Loading...
Phabricator · Built by Phacility