Page MenuHomePhabricator

Un-hide the "X added reviewers: ..." transactions in revision creation mail
ClosedPublic

Authored by epriestley on Sep 6 2017, 4:45 PM.
Tags
None
Referenced Files
F15482647: D18542.id44541.diff
Wed, Apr 9, 6:48 AM
F15465878: D18542.id44536.diff
Thu, Apr 3, 12:02 AM
F15464512: D18542.id44541.diff
Wed, Apr 2, 10:08 AM
F15461917: D18542.id.diff
Tue, Apr 1, 12:17 PM
F15460530: D18542.diff
Mon, Mar 31, 11:37 PM
F15441467: D18542.diff
Wed, Mar 26, 6:23 PM
F15425969: D18542.diff
Sun, Mar 23, 6:46 AM
F15416126: D18542.id.diff
Mar 20 2025, 9:24 AM
Subscribers
None

Details

Summary

Fixes T12118. See PHI54. This adds a special case for the initial "reviewers" transactions, similar to the existing special case for "projects" transactions.

Although these transactions are redudnant in the web view since you can see the information clearly on the page, they're more reasonably useful in mail.

Test Plan

Screen Shot 2017-09-06 at 9.43.17 AM.png (167×367 px, 17 KB)

Diff Detail

Repository
rP Phabricator
Branch
diffm1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18319
Build 24654: Run Core Tests
Build 24653: arc lint + arc unit