Page MenuHomePhabricator
Differential D18501

Add a selected button ui state
ClosedPublic
Actions

Authored by chad on Aug 30 2017, 4:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 22, 11:24 PM
Unknown Object (File)
Wed, Jan 22, 7:43 AM
Unknown Object (File)
Tue, Jan 21, 11:10 AM
Unknown Object (File)
Sat, Jan 18, 12:57 AM
Unknown Object (File)
Tue, Jan 14, 9:17 PM
Unknown Object (File)
Fri, Jan 10, 12:00 AM
Unknown Object (File)
Sat, Dec 28, 2:26 PM
Unknown Object (File)
Dec 25 2024, 9:16 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP11046d495dbf: Add a selected button ui state
Summary

Only for grey buttons, but can expand. Sets a selected class.

Test Plan

Review new changes in UIExamples.

Diff Detail

Repository
rP Phabricator
Branch
selected-button (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18220
Build 24503: Run Core Tests
Build 24502: arc lint + arc unit

Event Timeline

chad created this revision.Aug 30 2017, 4:54 PM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 30 2017, 4:54 PM
Harbormaster completed remote builds in B18218: Diff 44433.Aug 30 2017, 4:55 PM
epriestley accepted this revision.Aug 30 2017, 4:56 PM
epriestley added inline comments.
webroot/rsrc/js/phuix/PHUIXButtonView.js
50–54

Simpler as:

this._selected = selected;
JX.DOM.alterClass(node, 'selected', this._selected);
This revision is now accepted and ready to land.Aug 30 2017, 4:56 PM
chad updated this revision to Diff 44435.Aug 30 2017, 5:01 PM
  • simpler
Harbormaster completed remote builds in B18220: Diff 44435.Aug 30 2017, 5:02 PM
Closed by commit rP11046d495dbf: Add a selected button ui state (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 30 2017, 5:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
applications/
uiexample/
examples/
4 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
phui/
button/
13 lines
js/
phuix/
8 lines

Diff 44435

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/uiexample/examples/PHUIButtonExample.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
View Options

webroot/rsrc/css/phui/button/phui-button.css

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXButtonView.js

Loading...
Phabricator · Built by Phacility