Page MenuHomePhabricator

Fix an issue where "Close Revision" did not appear in the UI
ClosedPublic

Authored by epriestley on Aug 29 2017, 4:55 PM.
Tags
None
Referenced Files
F14724706: D18490.id44415.diff
Sat, Jan 18, 1:40 AM
Unknown Object (File)
Sun, Jan 12, 7:42 PM
Unknown Object (File)
Fri, Jan 3, 5:34 AM
Unknown Object (File)
Sun, Dec 29, 9:03 PM
Unknown Object (File)
Fri, Dec 20, 6:58 PM
Unknown Object (File)
Dec 13 2024, 8:03 PM
Unknown Object (File)
Dec 11 2024, 10:08 PM
Unknown Object (File)
Dec 7 2024, 9:12 PM
Subscribers
None

Details

Summary

Ref T2543. When called from the UI to build the dropdown, there's no Editor, since we aren't actually in an edit flow.

This logic worked for actually performing the edits, just not for getting the option into the dropdown.

Test Plan

Used the dropdown to close an "Accepted" revision which I authored.

Diff Detail

Repository
rP Phabricator
Branch
close1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18202
Build 24476: Run Core Tests
Build 24475: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 29 2017, 4:57 PM

Specifically, getEditor() would throw, and the caller would interpret that as "action isn't available".

I'm going to cherry-pick and hotfix this.

This revision was automatically updated to reflect the committed changes.