Fix float issue on diffusion blame view
ClosedPublic
Actions

Authored by chad on Aug 24 2017, 7:01 PM.

Tags

None

Referenced Files

	F15589458: D18462.diff
	Fri, May 9, 1:44 PM

	F15583768: D18462.diff
	Wed, May 7, 11:36 PM

	F15577342: D18462.id44352.diff
	Tue, May 6, 1:31 PM

	F15573174: D18462.diff
	Mon, May 5, 7:49 PM

	F15563259: D18462.diff
	Wed, Apr 30, 7:11 AM

	F15507768: D18462.diff
	Tue, Apr 15, 10:38 PM

	F15462973: D18462.id44352.diff
	Apr 1 2025, 7:24 PM

	F15461779: D18462.id44354.diff
	Apr 1 2025, 11:14 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP0a013341721f: Fix float issue on diffusion blame view

Summary

These items should be floated, not display: block.

Test Plan

Test blame view with commits AND revisions, check they display inline.

Diff Detail

Repository

rP Phabricator

Branch

diffusion-blame (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18140
Build 24382: Run Core Tests
Build 24381: arc lint + arc unit

Event Timeline

chad created this revision.Aug 24 2017, 7:01 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 24 2017, 7:01 PM

Harbormaster completed remote builds in B18140: Diff 44352.Aug 24 2017, 7:02 PM

epriestley accepted this revision.Aug 24 2017, 7:04 PM

This revision is now accepted and ready to land.Aug 24 2017, 7:04 PM

Closed by commit rP0a013341721f: Fix float issue on diffusion blame view (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 24 2017, 7:05 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D18746: Revert changes to Diffusion blame view.Oct 31 2017, 6:04 PM

epriestley mentioned this in rP90d0f8ac6cf5: Revert changes to Diffusion blame view.Oct 31 2017, 6:54 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

diffusion/

diffusion-source.css

2 lines

Diff 44352

View Options

resources/celerity/map.php