Redirect users back to where they added an SSH Key
ClosedPublic
Actions

Authored by chad on Aug 18 2017, 4:24 PM.

Tags

None

Referenced Files

	F14757215: D18445.id44317.diff
	Tue, Jan 21, 11:44 PM

	Unknown Object (File)
	Tue, Jan 21, 12:51 PM

	Unknown Object (File)
	Sun, Jan 12, 11:16 PM

	Unknown Object (File)
	Tue, Dec 31, 8:29 PM

	Unknown Object (File)
	Mon, Dec 30, 4:28 AM

	Unknown Object (File)
	Sun, Dec 29, 6:25 PM

	Unknown Object (File)
	Fri, Dec 27, 5:15 PM

	Unknown Object (File)
	Dec 14 2024, 5:33 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12964: SSH Key adding workflows could use better UX

Commits

rP39d19c33ec9c: Redirect users back to where they added an SSH Key

Summary

Ref T12964. This feels like a cheat, but works well. Just redirect the user back to the form they came from instead of to the key page.

Test Plan

Add a key to a user profile, add a key to an Alamanac device. Grep for PhabricatorAuthSSHKeyTableView and check all locations.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Aug 18 2017, 4:24 PM

Herald added a subscriber: Korvin. · View Herald TranscriptAug 18 2017, 4:24 PM

Harbormaster completed remote builds in B18107: Diff 44317.Aug 18 2017, 4:25 PM

epriestley accepted this revision.Aug 21 2017, 8:51 PM

This revision is now accepted and ready to land.Aug 21 2017, 8:51 PM

Closed by commit rP39d19c33ec9c: Redirect users back to where they added an SSH Key (authored by Chad Little <chad@phacility.com>). · Explain WhyAug 21 2017, 9:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

PhabricatorAuthSSHKeyEditController.php

2 lines

Diff 44324

View Options

src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php

Redirect users back to where they added an SSH KeyClosedPublicActions