Page MenuHomePhabricator

Fix a possible database ref fatal during MySQL setup checks if a host is unreachable
ClosedPublic

Authored by epriestley on Aug 17 2017, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 8:09 AM
Unknown Object (File)
Fri, May 3, 7:51 AM
Unknown Object (File)
Mon, Apr 29, 5:48 PM
Unknown Object (File)
Mon, Apr 29, 5:47 PM
Unknown Object (File)
Mon, Apr 29, 5:47 PM
Unknown Object (File)
Thu, Apr 25, 6:27 PM
Unknown Object (File)
Thu, Apr 25, 1:48 AM
Unknown Object (File)
Mar 5 2024, 4:11 PM
Subscribers
None

Details

Summary

Ref T12966. See that task for a description and reproduction steps.

If you put Phabricator in a master/replica configuration and then restart it, we may fatal here if the master is unreachable. Instead, we should survive setup checks.

Test Plan

Put Phabricator in a master/replica configuration, explicitly disabled the master by misconfiguring the port, restarted Phabricator. Before: fatal; after: login screen in read-only mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable