Page MenuHomePhabricator

Fix a possible database ref fatal during MySQL setup checks if a host is unreachable
ClosedPublic

Authored by epriestley on Aug 17 2017, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 19 2024, 7:01 AM
Unknown Object (File)
Sep 21 2024, 11:04 PM
Unknown Object (File)
Sep 20 2024, 9:56 AM
Unknown Object (File)
Sep 6 2024, 12:52 AM
Unknown Object (File)
Sep 5 2024, 12:33 PM
Unknown Object (File)
Sep 4 2024, 9:05 AM
Unknown Object (File)
Aug 29 2024, 7:40 AM
Unknown Object (File)
Aug 26 2024, 3:40 AM
Subscribers
None

Details

Summary

Ref T12966. See that task for a description and reproduction steps.

If you put Phabricator in a master/replica configuration and then restart it, we may fatal here if the master is unreachable. Instead, we should survive setup checks.

Test Plan

Put Phabricator in a master/replica configuration, explicitly disabled the master by misconfiguring the port, restarted Phabricator. Before: fatal; after: login screen in read-only mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable