Page MenuHomePhabricator

Fix a possible database ref fatal during MySQL setup checks if a host is unreachable
ClosedPublic

Authored by epriestley on Aug 17 2017, 6:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 7 2026, 3:06 AM
Unknown Object (File)
Apr 2 2026, 8:17 PM
Unknown Object (File)
Dec 23 2025, 3:08 AM
Unknown Object (File)
Dec 21 2025, 7:26 PM
Unknown Object (File)
Dec 10 2025, 6:26 AM
Unknown Object (File)
Dec 1 2025, 11:55 PM
Unknown Object (File)
Oct 31 2025, 7:53 AM
Unknown Object (File)
Oct 20 2025, 4:09 AM
Subscribers
None

Details

Summary

Ref T12966. See that task for a description and reproduction steps.

If you put Phabricator in a master/replica configuration and then restart it, we may fatal here if the master is unreachable. Instead, we should survive setup checks.

Test Plan

Put Phabricator in a master/replica configuration, explicitly disabled the master by misconfiguring the port, restarted Phabricator. Before: fatal; after: login screen in read-only mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable