Page MenuHomePhabricator

Fix a possible database ref fatal during MySQL setup checks if a host is unreachable
ClosedPublic

Authored by epriestley on Aug 17 2017, 6:35 PM.
Tags
None
Referenced Files
F18811655: D18442.diff
Mon, Oct 20, 4:09 AM
F18777339: D18442.diff
Sat, Oct 11, 2:17 AM
F18775903: D18442.id.diff
Fri, Oct 10, 8:36 PM
F18763949: D18442.id44309.diff
Tue, Oct 7, 3:15 AM
F18733723: D18442.id.diff
Tue, Sep 30, 10:40 PM
F18548783: D18442.id.diff
Sep 8 2025, 8:06 AM
F18537194: D18442.diff
Sep 7 2025, 2:50 PM
F18509013: D18442.id.diff
Sep 5 2025, 3:09 AM
Subscribers
None

Details

Summary

Ref T12966. See that task for a description and reproduction steps.

If you put Phabricator in a master/replica configuration and then restart it, we may fatal here if the master is unreachable. Instead, we should survive setup checks.

Test Plan

Put Phabricator in a master/replica configuration, explicitly disabled the master by misconfiguring the port, restarted Phabricator. Before: fatal; after: login screen in read-only mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable