Page MenuHomePhabricator

Make the default ApplicationSearch query explicit, not just the first item in the list
ClosedPublic

Authored by epriestley on Aug 14 2017, 6:13 PM.
Tags
None
Referenced Files
F15585517: D18422.id44365.diff
Thu, May 8, 9:35 AM
F15578551: D18422.id44275.diff
Tue, May 6, 7:42 PM
F15560802: D18422.id44275.diff
Tue, Apr 29, 4:40 PM
F15560592: D18422.id44267.diff
Tue, Apr 29, 3:29 PM
F15556526: D18422.id44365.diff
Mon, Apr 28, 5:10 PM
F15550775: D18422.id.diff
Sun, Apr 27, 1:36 PM
F15544707: D18422.diff
Sat, Apr 26, 6:41 AM
F15543171: D18422.id44267.diff
Fri, Apr 25, 9:32 PM
Subscribers
None

Details

Summary

Ref T12956. Currently, when you visit /maniphest/ (or any other ApplicationSearch application) we execute the first query in the list by default.

In T12956, I plan to make changes so that personal queries are always first, then global/builtin queries. Without changing the "default query" rule, this will make it harder to have, for example, some custom queries in Differential but still run a global query like "Active" by default. To make this work, you'd have to save a personal copy of the "Active" query, then put it at the top.

This feels a bit cumbersome and this rule is kind of implicit and a little weird anyway. To make this work a little better as we make changes here, add an explicit pinning action, like the one we have in Project ProfileMenus.

You can now explicitly choose a query to make default.

Test Plan
  • Browsed without pinning anything, saw normal behavior.
  • Pinned queries, viewed /maniphest/, saw a non-initial query selected by default.
  • Pinned a query, deleted it, nothing exploded.

Screen Shot 2017-08-14 at 11.05.40 AM.png (1×1 px, 154 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable