Page MenuHomePhabricator

Make the default ApplicationSearch query explicit, not just the first item in the list
ClosedPublic

Authored by epriestley on Aug 14 2017, 6:13 PM.

Details

Summary

Ref T12956. Currently, when you visit /maniphest/ (or any other ApplicationSearch application) we execute the first query in the list by default.

In T12956, I plan to make changes so that personal queries are always first, then global/builtin queries. Without changing the "default query" rule, this will make it harder to have, for example, some custom queries in Differential but still run a global query like "Active" by default. To make this work, you'd have to save a personal copy of the "Active" query, then put it at the top.

This feels a bit cumbersome and this rule is kind of implicit and a little weird anyway. To make this work a little better as we make changes here, add an explicit pinning action, like the one we have in Project ProfileMenus.

You can now explicitly choose a query to make default.

Test Plan
  • Browsed without pinning anything, saw normal behavior.
  • Pinned queries, viewed /maniphest/, saw a non-initial query selected by default.
  • Pinned a query, deleted it, nothing exploded.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Aug 14 2017, 6:13 PM
epriestley updated this revision to Diff 44275.Aug 14 2017, 7:19 PM
  • Fix typo of "disalbed".
chad accepted this revision.Aug 14 2017, 10:46 PM
This revision is now accepted and ready to land.Aug 14 2017, 10:46 PM
This revision was automatically updated to reflect the committed changes.