Page MenuHomePhabricator

Make the default ApplicationSearch query explicit, not just the first item in the list

Authored by epriestley on Aug 14 2017, 6:13 PM.
Referenced Files
F12178992: D18422.diff
Mon, Sep 11, 8:07 PM
F12166981: D18422.diff
Thu, Sep 7, 2:14 AM
F12149111: D18422.diff
Sat, Sep 2, 6:39 AM
F12138707: D18422.diff
Aug 27 2023, 5:43 PM
Unknown Object (File)
Jul 25 2023, 1:47 PM
Unknown Object (File)
Jul 17 2023, 6:08 AM
Unknown Object (File)
Jun 16 2023, 6:10 PM
Unknown Object (File)
Jun 10 2023, 1:33 PM



Ref T12956. Currently, when you visit /maniphest/ (or any other ApplicationSearch application) we execute the first query in the list by default.

In T12956, I plan to make changes so that personal queries are always first, then global/builtin queries. Without changing the "default query" rule, this will make it harder to have, for example, some custom queries in Differential but still run a global query like "Active" by default. To make this work, you'd have to save a personal copy of the "Active" query, then put it at the top.

This feels a bit cumbersome and this rule is kind of implicit and a little weird anyway. To make this work a little better as we make changes here, add an explicit pinning action, like the one we have in Project ProfileMenus.

You can now explicitly choose a query to make default.

Test Plan
  • Browsed without pinning anything, saw normal behavior.
  • Pinned queries, viewed /maniphest/, saw a non-initial query selected by default.
  • Pinned a query, deleted it, nothing exploded.

Screen Shot 2017-08-14 at 11.05.40 AM.png (1×1 px, 154 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable