Lightly modernize NamedQueryQuery
ClosedPublic
Actions

Authored by epriestley on Aug 14 2017, 4:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 21, 3:26 PM

	Unknown Object (File)
	Tue, Feb 18, 4:09 AM

	Unknown Object (File)
	Sun, Feb 16, 8:39 PM

	Unknown Object (File)
	Wed, Feb 12, 6:45 AM

	Unknown Object (File)
	Fri, Feb 7, 6:03 PM

	Unknown Object (File)
	Fri, Jan 31, 11:18 AM

	Unknown Object (File)
	Tue, Jan 28, 2:47 AM

	Unknown Object (File)
	Tue, Jan 28, 2:47 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu

Commits

rP8c3243ef6870: Lightly modernize NamedQueryQuery

Summary

Ref T12956. No real behavioral changes here, just slightly more modern code.

Test Plan

Reviewed named queries in Maniphest and "Edit Queries...".

Diff Detail

Repository

rP Phabricator

Branch

item1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18056
Build 24253: Run Core Tests
Build 24252: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 14 2017, 4:01 PM

Harbormaster completed remote builds in B18056: Diff 44264.Aug 14 2017, 4:02 PM

chad accepted this revision.Aug 14 2017, 4:03 PM

This revision is now accepted and ready to land.Aug 14 2017, 4:03 PM

Closed by commit rP8c3243ef6870: Lightly modernize NamedQueryQuery (authored by epriestley). · Explain WhyAug 14 2017, 4:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

query/

PhabricatorNamedQueryQuery.php

41 lines

Diff 44264

View Options

src/applications/search/query/PhabricatorNamedQueryQuery.php

Lightly modernize NamedQueryQueryClosedPublicActions