Use modern revision statuses when bucketing revisions on the Differential dashboard
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 10:45 PM.

Tags

None

Referenced Files

	F18851554: D18414.id44249.diff
	Fri, Oct 31, 2:13 AM

	F18850768: D18414.id44258.diff
	Thu, Oct 30, 7:14 PM

	F18844063: D18414.id.diff
	Wed, Oct 29, 2:54 AM

	F18831168: D18414.id44258.diff
	Sat, Oct 25, 11:26 AM

	F18776070: D18414.id.diff
	Fri, Oct 10, 9:06 PM

	F18774175: D18414.diff
	Thu, Oct 9, 3:40 PM

	F18701175: D18414.diff
	Sep 27 2025, 5:47 PM

	F18658710: D18414.id44249.diff
	Sep 23 2025, 7:58 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP895f0cde1f0a: Use modern revision statuses when bucketing revisions on the Differential…

Summary

Ref T2543. Swaps these over to modern constants.

Test Plan

Viewed dashboard, no chagnes to bucketing.

Diff Detail

Repository

rP Phabricator

Branch

status15

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18041
Build 24232: Run Core Tests
Build 24231: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 11 2017, 10:45 PM

Harbormaster completed remote builds in B18041: Diff 44249.Aug 11 2017, 10:46 PM

chad accepted this revision.Aug 11 2017, 10:50 PM

This revision is now accepted and ready to land.Aug 11 2017, 10:50 PM

Closed by commit rP895f0cde1f0a: Use modern revision statuses when bucketing revisions on the Differential… (authored by epriestley, committed by epriestley). · Explain WhyAug 12 2017, 12:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionRequiredActionResultBucket.php

16 lines

storage/

DifferentialRevision.php

4 lines

Diff 44249

View Options

src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php