Differential D18400

Provide revision status information via API all "differential.revision.search"
ClosedPublic
Actions

Authored by epriestley on Aug 11 2017, 4:53 PM.

Details

Reviewers

chad

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rP36197bf783e4: Provide revision status information via API all "differential.revision.search"

Summary

Ref T2543. Now that the integer status constants are banished to the internals, we can expose status information from "differential.revision.search".

Test Plan

Searched for revisions.

Screen Shot 2017-08-11 at 9.51.59 AM.png (483×694 px, 77 KB)

Diff Detail

Repository

rP Phabricator

Branch

status9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18013
Build 24197: Run Core Tests
Build 24196: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 11 2017, 4:53 PM

Harbormaster completed remote builds in B18013: Diff 44215.Aug 11 2017, 4:54 PM

chad accepted this revision.Aug 11 2017, 5:35 PM

This revision is now accepted and ready to land.Aug 11 2017, 5:35 PM

Closed by commit rP36197bf783e4: Provide revision status information via API all "differential.revision.search" (authored by epriestley, committed by epriestley). · Explain WhyAug 11 2017, 8:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

constants/

DifferentialRevisionStatus.php

4 lines

storage/

DifferentialRevision.php

13 lines

Diff 44215

View Options

src/applications/differential/constants/DifferentialRevisionStatus.php