Page MenuHomePhabricator

Remove old reviewer double writes to legacy edge table in Differential
ClosedPublic

Authored by epriestley on Aug 11 2017, 4:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 1 2024, 10:53 PM
Unknown Object (File)
Dec 27 2023, 11:50 AM
Unknown Object (File)
Dec 27 2023, 11:49 AM
Unknown Object (File)
Dec 27 2023, 11:49 AM
Unknown Object (File)
Dec 24 2023, 4:25 PM
Unknown Object (File)
Dec 23 2023, 12:46 AM
Unknown Object (File)
Dec 22 2023, 10:44 AM
Unknown Object (File)
Dec 21 2023, 8:30 PM
Subscribers
None

Details

Summary

Ref T2543. Ref T10967. This isn't precisely related to "draft" status, but while I'm churning this stuff anyway, get rid of the old double writes to clean the code up a bit.

These were added in T10967 to make sure the migration was reversible/recoverable, but we haven't seen any issues with it in several months so I believe they can now be removed safely. Nothing has read this table since ~April.

Test Plan

Took various review actions on revisions (accept, reject, resign, comment, etc). If this change is correct, there should be no visible effect.

Diff Detail

Repository
rP Phabricator
Branch
status7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18011
Build 24193: Run Core Tests
Build 24192: arc lint + arc unit