Page MenuHomePhabricator

Remove old reviewer double writes to legacy edge table in Differential
ClosedPublic

Authored by epriestley on Aug 11 2017, 4:47 PM.
Tags
None
Referenced Files
F15701248: D18398.id.diff
Wed, May 28, 6:56 PM
Unknown Object (File)
Tue, May 27, 5:55 PM
Unknown Object (File)
Apr 27 2025, 6:29 AM
Unknown Object (File)
Apr 25 2025, 6:47 PM
Unknown Object (File)
Apr 25 2025, 1:49 AM
Unknown Object (File)
Apr 24 2025, 3:55 PM
Unknown Object (File)
Apr 21 2025, 11:41 PM
Unknown Object (File)
Apr 5 2025, 5:08 PM
Subscribers
None

Details

Summary

Ref T2543. Ref T10967. This isn't precisely related to "draft" status, but while I'm churning this stuff anyway, get rid of the old double writes to clean the code up a bit.

These were added in T10967 to make sure the migration was reversible/recoverable, but we haven't seen any issues with it in several months so I believe they can now be removed safely. Nothing has read this table since ~April.

Test Plan

Took various review actions on revisions (accept, reject, resign, comment, etc). If this change is correct, there should be no visible effect.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable