Page MenuHomePhabricator

Remove old reviewer double writes to legacy edge table in Differential
ClosedPublic

Authored by epriestley on Aug 11 2017, 4:47 PM.
Tags
None
Referenced Files
F18180268: D18398.id44213.diff
Sat, Aug 16, 5:58 AM
F18170826: D18398.id.diff
Fri, Aug 15, 6:21 PM
F18153252: D18398.diff
Thu, Aug 14, 7:30 PM
F18094879: D18398.id.diff
Thu, Aug 7, 10:24 PM
F17847422: D18398.id44213.diff
Sun, Jul 27, 6:07 AM
Unknown Object (File)
Jul 8 2025, 12:25 AM
Unknown Object (File)
Jun 30 2025, 8:43 AM
Unknown Object (File)
Jun 30 2025, 7:15 AM
Subscribers
None

Details

Summary

Ref T2543. Ref T10967. This isn't precisely related to "draft" status, but while I'm churning this stuff anyway, get rid of the old double writes to clean the code up a bit.

These were added in T10967 to make sure the migration was reversible/recoverable, but we haven't seen any issues with it in several months so I believe they can now be removed safely. Nothing has read this table since ~April.

Test Plan

Took various review actions on revisions (accept, reject, resign, comment, etc). If this change is correct, there should be no visible effect.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable