Page MenuHomePhabricator

Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator
ClosedPublic

Authored by epriestley on Aug 4 2017, 12:33 PM.
Tags
None
Referenced Files
F15440303: D18339.id.diff
Wed, Mar 26, 11:59 AM
F15420991: D18339.id44092.diff
Fri, Mar 21, 7:55 PM
F15381430: D18339.id44158.diff
Fri, Mar 14, 7:37 AM
F15365664: D18339.diff
Tue, Mar 11, 2:02 PM
Unknown Object (File)
Mon, Mar 3, 11:06 AM
Unknown Object (File)
Mon, Mar 3, 7:16 AM
Unknown Object (File)
Feb 11 2025, 8:58 AM
Unknown Object (File)
Jan 24 2025, 10:30 PM
Subscribers
Restricted Owners Package

Details

Summary

Ref T2543. These are currently numeric values, like "0" and "3". I want to replace them with strings, like "accepted", and move definitions from Arcanist to Phabricator.

To set the stage for this, reduce the number of callsites where Phabricator invokes ArcanistDifferentialRevisionStatus.

This is just the easy ones. I'll hold this until the release cut.

Test Plan
  • Called differential.find.
  • Called differential.getrevision.
  • Called differential.query.
  • Removed all reviewers from a revision, saw warning.
  • Abandoned the no-reviewers revision, no more warning.
  • Attached a revision to a task to get it to show the state icon with the status on a tooltip.
  • Viewed revision bucketing on dashboard.
  • Used bin/search index to reindex a revision.
  • Hit the "Land Revision" endpoint.

I didn't explicitly test these cases:

  • Doorkeeper Asana integration, since setup takes a thousand years.
  • Disambiguation logic when multiple hashes match, since setup is also very involved.
  • Releeph because it's Releeph.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a subscriber: Restricted Owners Package.Aug 4 2017, 12:33 PM
This revision is now accepted and ready to land.Aug 4 2017, 5:03 PM
This revision was automatically updated to reflect the committed changes.