Page MenuHomePhabricator
Differential D18332

Allow setting of tabs at StandardPageView
ClosedPublic
Actions

Authored by chad on Aug 3 2017, 11:52 PM.
Tags
None
Referenced Files
F14045303: D18332.id44078.diff
Wed, Nov 13, 2:43 AM
F14001279: D18332.id44083.diff
Fri, Oct 25, 5:58 AM
F13975793: D18332.diff
Fri, Oct 18, 11:40 AM
F13972119: D18332.id44078.diff
Oct 17 2024, 5:13 PM
Unknown Object (File)
Oct 6 2024, 5:04 AM
Unknown Object (File)
Oct 4 2024, 5:37 PM
Unknown Object (File)
Oct 4 2024, 7:00 AM
Unknown Object (File)
Oct 4 2024, 6:59 AM
View All 78 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rPfedf08743ffd: Allow setting of tabs at StandardPageView
Summary

Rather than have tabs live in two column view, sometimes like admin we'll want a global set of tabs that work well with all layouts and crumbs.

Test Plan

I tested this in an upcoming diff for instances.

image.png (1×2 px, 290 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Aug 3 2017, 11:52 PM
Herald added a subscriber: Korvin. · View Herald TranscriptAug 3 2017, 11:52 PM
Harbormaster completed remote builds in B17897: Diff 44078.Aug 3 2017, 11:53 PM
chad edited the test plan for this revision. (Show Details)Aug 3 2017, 11:58 PM

btw im assuming we're merging 'pacts' and 'support' to just 'support' once dust clears.

epriestley accepted this revision.Aug 4 2017, 1:28 AM
This revision is now accepted and ready to land.Aug 4 2017, 1:28 AM
Closed by commit rPfedf08743ffd: Allow setting of tabs at StandardPageView (authored by chad, committed by chad). · Explain WhyAug 4 2017, 2:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
page/
21 lines
webroot/
rsrc/
css/
application/
base/
11 lines

Diff 44083

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/application/base/standard-page-view.css

Loading...
Phabricator · Built by Phacility