Page MenuHomePhabricator
Differential D18262

Fix an issue when deleting the entire content of an unsubmitted inline comment
ClosedPublic
Actions

Authored by epriestley on Jul 21 2017, 3:10 PM.
Tags
None
Referenced Files
F13141973: D18262.diff
Fri, May 3, 5:25 AM
Unknown Object (File)
Thu, Apr 25, 1:10 AM
Unknown Object (File)
Fri, Apr 19, 6:39 PM
Unknown Object (File)
Wed, Apr 17, 12:26 PM
Unknown Object (File)
Wed, Apr 10, 5:30 PM
Unknown Object (File)
Mon, Apr 8, 11:43 AM
Unknown Object (File)
Mon, Apr 8, 5:24 AM
Unknown Object (File)
Mon, Apr 8, 5:24 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP0d8f4170f4dc: Fix an issue when deleting the entire content of an unsubmitted inline comment
Summary

Ref T12733. In this case, the server returns no new row, but we would incorrectly try to bind to one.

Test Plan
  • Created a new comment.
  • Edited it.
  • Deleted all the text.
  • Saved changes.
  • Before: Header continues to show phantom "1 Unsubmitted Comment", browser error log reflects one error.
  • After: Header reflects comment being deleted, error log is quiet.

Diff Detail

Repository
rP Phabricator
Branch
unsaved1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17770
Build 23861: Run Core Tests
Build 23860: arc lint + arc unit

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
webroot/
rsrc/
js/
application/
diff/
9 lines

Diff 43917

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility