Paths

Table of Contentst

Differential D18262

Fix an issue when deleting the entire content of an unsubmitted inline comment
ClosedPublic
Actions

Authored by epriestley on Jul 21 2017, 3:10 PM.

Details

Reviewers

chad

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rP0d8f4170f4dc: Fix an issue when deleting the entire content of an unsubmitted inline comment

Summary

Ref T12733. In this case, the server returns no new row, but we would incorrectly try to bind to one.

Test Plan

Created a new comment.
Edited it.
Deleted all the text.
Saved changes.
Before: Header continues to show phantom "1 Unsubmitted Comment", browser error log reflects one error.
After: Header reflects comment being deleted, error log is quiet.

Diff Detail

Repository

rP Phabricator

Branch

unsaved1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17770
Build 23861: Run Core Tests
Build 23860: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 21 2017, 3:10 PM

chad accepted this revision.Jul 21 2017, 3:11 PM

This revision is now accepted and ready to land.Jul 21 2017, 3:11 PM

Harbormaster completed remote builds in B17770: Diff 43917.Jul 21 2017, 3:11 PM

Closed by commit rP0d8f4170f4dc: Fix an issue when deleting the entire content of an unsubmitted inline comment (authored by epriestley, committed by epriestley). · Explain WhyJul 21 2017, 3:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

12 lines

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

9 lines

Diff 43917

View Options

resources/celerity/map.php