Differential D18239

Lots of little fixes for Dark Mode (Experimental)
ClosedPublic
Actions

Authored by chad on Jul 18 2017, 11:25 PM.

Details

Reviewers

epriestley

Commits

rP2f26dd76de90: Lots of little fixes for Dark Mode (Experimental)

Summary

Cleans up a bunch of Differential odd/special colors. Adds some basic "highlight" colors instead of pure yellow.

Test Plan

Test each color change in normal and dark modes.

Diff Detail

Repository

rP Phabricator

Branch

differential-dark-1 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17749
Build 23834: Run Core Tests
Build 23833: arc lint + arc unit

Event Timeline

chad created this revision.Jul 18 2017, 11:25 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJul 18 2017, 11:25 PM

Harbormaster completed remote builds in B17732: Diff 43868.Jul 18 2017, 11:26 PM

fix NOTES, Highlight, other remarkup color

epriestley accepted this revision.Jul 19 2017, 9:40 PM

This revision is now accepted and ready to land.Jul 19 2017, 9:40 PM

Closed by commit rP2f26dd76de90: Lots of little fixes for Dark Mode (Experimental) (authored by chad, committed by chad). · Explain WhyJul 19 2017, 9:41 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B17749: Diff 43888.Jul 19 2017, 9:41 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

46 lines

src/

applications/

celerity/

postprocessor/

CelerityDarkModePostprocessor.php

26 lines

CelerityDefaultPostprocessor.php

6 lines

webroot/

rsrc/

css/

application/

config/

config-options.css

2 lines

differential/

changeset-view.css

16 lines

phui-inline-comment.css

10 lines

core/

remarkup.css

2 lines

diviner/

diviner-shared.css

2 lines

phui/

button/

phui-button-bar.css

4 lines

phui-basic-nav-view.css

2 lines

phui-comment-form.css

2 lines

phui-timeline-view.css

4 lines

Diff 43888

View Options

resources/celerity/map.php

View Options

src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php

View Options

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

View Options

webroot/rsrc/css/application/config/config-options.css

View Options

webroot/rsrc/css/application/differential/changeset-view.css

View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

View Options

webroot/rsrc/css/core/remarkup.css

View Options

webroot/rsrc/css/diviner/diviner-shared.css

View Options

webroot/rsrc/css/phui/button/phui-button-bar.css

View Options

webroot/rsrc/css/phui/phui-basic-nav-view.css

View Options

webroot/rsrc/css/phui/phui-comment-form.css

View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Lots of little fixes for Dark Mode (Experimental)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43888

resources/celerity/map.php

src/applications/celerity/postprocessor/CelerityDarkModePostprocessor.php

src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php

webroot/rsrc/css/application/config/config-options.css

webroot/rsrc/css/application/differential/changeset-view.css

webroot/rsrc/css/application/differential/phui-inline-comment.css

webroot/rsrc/css/core/remarkup.css

webroot/rsrc/css/diviner/diviner-shared.css

webroot/rsrc/css/phui/button/phui-button-bar.css

webroot/rsrc/css/phui/phui-basic-nav-view.css

webroot/rsrc/css/phui/phui-comment-form.css

webroot/rsrc/css/phui/phui-timeline-view.css

Lots of little fixes for Dark Mode (Experimental)
ClosedPublic
Actions

Revision Contents
Changeset List