Mostly this is an exercise to clean up our CSS and Celerity processor by making sure all important color decisions are generatable. It's somewhat resonable to use if you don't review code. Posting it up here mostly so I don't lose the work.
Details
- Reviewers
epriestley - Commits
- rP7aeefc0cca5d: Add an Experimental Dark Mode to Phabricator
Visit lots and lots of pages with dark mode on and off.
Diff Detail
- Repository
- rP Phabricator
- Branch
- dark-mode (branched from master)
- Lint
Lint Warnings Severity Location Code Message Warning webroot/rsrc/css/phui/phui-form.css:108 TXT3 Line Too Long - Unit
Tests Passed - Build Status
Buildable 17709 Build 23775: Run Core Tests Build 23774: arc lint + arc unit
Event Timeline
I think this is pretty reasonable on the technical side given that we've already built this stuff for general maintainability/consistency and accessibility if you want to move forward with it. Two broad thoughts:
One thing we could do is add, e.g., tabs or buttons something on UIExamples to let you toggle between themes without having to go mangle your settings.
The short TODO on this is:
- Highlight colors (like light yellow) maybe need to be individual variables.
- Diffs need work.
- Setup issues are hard coded.
But overall it came together faster and cleaner than I expected for just goofing around. I'd be OK landing this as it's labeled "experimental". Or I can pull the celerity processor out into a separate diff.
This is probably 96% complete. Some random bugs like setting workboard colors or conpherence rooms, but I'm going to put my fingers in my ears about them.
I think the "Experimental" label is fine, users can't complain to me anymore anyway. :) :) :) 😸 :) :) 11oneone