Mostly this is an exercise to clean up our CSS and Celerity processor by making sure all important color decisions are generatable. It's somewhat resonable to use if you don't review code. Posting it up here mostly so I don't lose the work.
- rP7aeefc0cca5d: Add an Experimental Dark Mode to Phabricator
Visit lots and lots of pages with dark mode on and off.
I think this is pretty reasonable on the technical side given that we've already built this stuff for general maintainability/consistency and accessibility if you want to move forward with it. Two broad thoughts:
The short TODO on this is:
- Highlight colors (like light yellow) maybe need to be individual variables.
- Diffs need work.
- Setup issues are hard coded.
But overall it came together faster and cleaner than I expected for just goofing around. I'd be OK landing this as it's labeled "experimental". Or I can pull the celerity processor out into a separate diff.