Page MenuHomePhabricator

Move Clone Repository to Dialog
ClosedPublic

Authored by chad on Jul 11 2017, 3:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 12:33 AM
Unknown Object (File)
Sat, Apr 27, 11:29 PM
Unknown Object (File)
Sat, Apr 27, 11:29 PM
Unknown Object (File)
Sat, Apr 27, 11:29 PM
Unknown Object (File)
Sat, Apr 27, 11:05 PM
Unknown Object (File)
Thu, Apr 11, 10:05 AM
Unknown Object (File)
Tue, Apr 2, 4:46 PM
Unknown Object (File)
Mar 31 2024, 2:03 PM
Subscribers

Details

Summary

This moves the clone details on the Repository Home to a button / dialog. Functionally this is to pull content on the page way up, while giving full space to all the clone options. I think we can build this into some FancyJS if needed, but this seems to clean ui the UI dramatically with little overhead. I don't want to attempt the JS dropdown unless we're sure that's the best path (it exposes the most common URI by default, saving a click).

Test Plan

Tested hg, svn, git repositories and the raw URL page. Test close button.

Diff Detail

Repository
rP Phabricator
Branch
clone-dialog (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17671
Build 23725: Run Core Tests
Build 23724: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jul 11 2017, 2:55 PM
This revision was automatically updated to reflect the committed changes.