I guess we have this magical method that tells me if a pager is coming down the render pipe. Huzzah.
Details
Details
- Reviewers
epriestley - Commits
- rP7408483c2f02: Hide Pager border if no pager exists
Test Branches page in Diffusion, see no pager border.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- pager-vanish (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17670 Build 23723: Run Core Tests Build 23722: arc lint + arc unit
Event Timeline
| src/view/phui/PHUIObjectBoxView.php | ||
|---|---|---|
| 306 | Maybe do the check here, instead, and just decline to render the pager rather than pretending it wasn't set. The current behavior makes this not work: $view->setPager($x); $x = $view->getPager(); We probably never do that and I don't know that getPager() even exists on this class, but a setX() method just ignoring that it was called feels like a flimsy pattern. | |