Differential D18193

Move actions into Diffusion header
ClosedPublic
Actions

Authored by chad on Jul 10 2017, 1:41 AM.

Tags

None

Referenced Files

	F15542357: D18193.id43766.diff
	Fri, Apr 25, 4:35 PM

	F15533818: D18193.diff
	Wed, Apr 23, 10:10 PM

	F15527610: D18193.id.diff
	Tue, Apr 22, 5:08 AM

	F15525895: D18193.diff
	Mon, Apr 21, 5:38 PM

	F15509449: D18193.id43766.diff
	Wed, Apr 16, 12:28 PM

	F15467583: D18193.id43766.diff
	Thu, Apr 3, 4:29 PM

	F15446419: D18193.diff
	Thu, Mar 27, 7:01 PM

	F15442296: D18193.id43766.diff
	Mar 26 2025, 10:37 PM

Subscribers

Details

Reviewers

Commits

rP646ad36b15b6: Move actions into Diffusion header

Summary

This moves actions into the Diffusion main header, removes the locate file box, and widens description and cloning details. Projects are not currently in this layout, but will follow up in another diff. Trying to keep these changes small and iterative.

Test Plan

Locate some files, test actions dropdown, repository with and without description. Also tablet, mobile layouts.

image.png (2×2 px, 576 KB)

Diff Detail

Repository

Branch

diffusion-actions-menu (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17655
Build 23703: Run Core Tests
Build 23702: arc lint + arc unit

Event Timeline

chad created this revision.Jul 10 2017, 1:41 AM

Herald added a subscriber: Korvin. · View Herald TranscriptJul 10 2017, 1:41 AM

Harbormaster completed remote builds in B17655: Diff 43766.Jul 10 2017, 1:42 AM

chad edited the test plan for this revision. (Show Details)Jul 10 2017, 1:44 AM

epriestley accepted this revision.Jul 10 2017, 1:50 PM

This revision is now accepted and ready to land.Jul 10 2017, 1:50 PM

Closed by commit rP646ad36b15b6: Move actions into Diffusion header (authored by chad, committed by chad). · Explain WhyJul 10 2017, 1:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

src/

applications/

diffusion/

controller/

DiffusionRepositoryController.php

46 lines

view/

DiffusionBranchListView.php

2 lines

DiffusionBrowseTableView.php

2 lines

DiffusionCommitListView.php

2 lines

DiffusionHistoryListView.php

2 lines

DiffusionTagListView.php

2 lines

view/

form/

control/

AphrontFormTypeaheadControl.php

7 lines

webroot/

rsrc/

css/

application/

diffusion/

diffusion-history.css

	diffusion.css
	diffusion-history.css

39 lines

Diff 43766

resources/celerity/map.php

Loading...

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...

src/applications/diffusion/view/DiffusionBranchListView.php

Loading...

src/applications/diffusion/view/DiffusionBrowseTableView.php

Loading...

src/applications/diffusion/view/DiffusionCommitListView.php

Loading...

src/applications/diffusion/view/DiffusionHistoryListView.php

Loading...

src/applications/diffusion/view/DiffusionTagListView.php

Loading...

src/view/form/control/AphrontFormTypeaheadControl.php

Loading...

webroot/rsrc/css/application/diffusion/diffusion-history.css

Loading...

webroot/rsrc/css/application/diffusion/diffusion.css

Loading...