Paths

Table of Contentst

Fix an issue where repositories with hyphens could sort improperly in typeaheads
ClosedPublic
Actions

Authored by epriestley on Jul 3 2017, 2:27 PM.

Tags

None

Referenced Files

	F15385151: D18179.id43733.diff
	Fri, Mar 14, 9:51 PM

	F15375263: D18179.diff
	Wed, Mar 12, 10:20 PM

	F15308371: D18179.diff
	Thu, Mar 6, 6:12 AM

	Unknown Object (File)
	Fri, Feb 28, 6:26 PM

	Unknown Object (File)
	Feb 9 2025, 4:24 AM

	Unknown Object (File)
	Feb 9 2025, 4:24 AM

	Unknown Object (File)
	Feb 9 2025, 4:24 AM

	Unknown Object (File)
	Feb 9 2025, 4:24 AM

View All Files

Subscribers

None

Details

Reviewers

chad
amckinley

Maniphest Tasks

T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first)

Commits

rPa6f018210466: Fix an issue where repositories with hyphens could sort improperly in typeaheads

Summary

Fixes T12894. See that task for discussion.

Test Plan

Created repositories abcdef, then abcdef-a through abcdef-f.
Before patch, awkward sort order.
After patch, query for abcdef hits abcdef first.
See T12894 for details and screenshots.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 3 2017, 2:27 PM

Harbormaster completed remote builds in B17622: Diff 43733.Jul 3 2017, 2:28 PM

chad accepted this revision.Jul 3 2017, 4:04 PM

This revision is now accepted and ready to land.Jul 3 2017, 4:04 PM

Closed by commit rPa6f018210466: Fix an issue where repositories with hyphens could sort improperly in typeaheads (authored by epriestley, committed by epriestley). · Explain WhyJul 3 2017, 4:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

typeahead/

DiffusionRepositoryDatasource.php

2 lines

Diff 43734

View Options

src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php

Fix an issue where repositories with hyphens could sort improperly in typeaheadsClosedPublicActions