Fixes T12840. This adds a parallel "graph" button next to history on home and on the history list page. I'll think more about better placement of how to get to this page with the upcoming redesign that's still sitting in Pholio.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12840: (maybe) bring back commit graphs in history
- Commits
- rPd0898116d8c2: Add a graph view page to Diffusion
View History, View Graph, Try pager, go to a file, click view history, see no graph button.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- diffusion-graph-history (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17518 Build 23497: Run Core Tests Build 23496: arc lint + arc unit
Event Timeline
Comment Actions
Why doesn't the graph draw for history on a path?
For example, if I browse to src/ → View History, I don't get an option to see the graph.
(I'd personally prefer to replace the "List" history with the "Graph" history in every case, but putting a "View Graph" next to every "View History" link probably doesn't make much sense...)
Comment Actions
This seems fine in any case, but I expect a graph of a path like src/maniphest/ to work; it represents a useful operation for answering questions like "Which of the recent Maniphest fixes got merged into stable?", which you can answer by going to src/maniphest/ then viewing the graph.
Comment Actions
Hmm, you're right. I don't know why that was the case. I guess we can sort it out in the future.
Comment Actions
It came from D2007. I think this was just a technical/scope restriction (since the feature was brand new), not an explicit product decision.
Comment Actions
The way we build parents may need to change to make it work if path is nonempty. I can fiddle with this later if I care.