Page MenuHomePhabricator

Add a graph view page to Diffusion
ClosedPublic

Authored by chad on Jun 18 2017, 7:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 7:25 PM
Unknown Object (File)
Sat, Mar 9, 10:54 PM
Unknown Object (File)
Sun, Mar 3, 2:42 PM
Unknown Object (File)
Feb 21 2024, 12:47 PM
Unknown Object (File)
Feb 16 2024, 4:54 AM
Unknown Object (File)
Jan 26 2024, 3:53 PM
Unknown Object (File)
Jan 23 2024, 9:27 AM
Unknown Object (File)
Dec 27 2023, 11:29 AM
Subscribers

Details

Summary

Fixes T12840. This adds a parallel "graph" button next to history on home and on the history list page. I'll think more about better placement of how to get to this page with the upcoming redesign that's still sitting in Pholio.

Test Plan

View History, View Graph, Try pager, go to a file, click view history, see no graph button.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Why doesn't the graph draw for history on a path?

For example, if I browse to src/View History, I don't get an option to see the graph.

(I'd personally prefer to replace the "List" history with the "Graph" history in every case, but putting a "View Graph" next to every "View History" link probably doesn't make much sense...)

This seems fine in any case, but I expect a graph of a path like src/maniphest/ to work; it represents a useful operation for answering questions like "Which of the recent Maniphest fixes got merged into stable?", which you can answer by going to src/maniphest/ then viewing the graph.

This revision is now accepted and ready to land.Jun 19 2017, 3:45 PM

Maybe I read the code wrong, but it didn't look like we showed a graph on paths?

Hmm, you're right. I don't know why that was the case. I guess we can sort it out in the future.

I tried it at first and it basically had a branch on every line.

|
|\
| \ \
|  \ \ \

It came from D2007. I think this was just a technical/scope restriction (since the feature was brand new), not an explicit product decision.

The way we build parents may need to change to make it work if path is nonempty. I can fiddle with this later if I care.

This revision was automatically updated to reflect the committed changes.