Page MenuHomePhabricator
Differential D18126

In the UI, rename "Hide Inline" to "Collapse Inline"
ClosedPublic
Actions

Authored by epriestley on Jun 15 2017, 11:19 AM.
Tags
None
Referenced Files
F15525092: D18126.id43617.diff
Mon, Apr 21, 12:13 PM
F15520346: D18126.id43617.diff
Sun, Apr 20, 5:42 AM
F15476469: D18126.diff
Mon, Apr 7, 6:16 AM
F15465786: D18126.id43620.diff
Wed, Apr 2, 11:08 PM
F15461732: D18126.id.diff
Tue, Apr 1, 10:49 AM
F15461285: D18126.id43617.diff
Tue, Apr 1, 6:59 AM
F15459879: D18126.id43620.diff
Mon, Mar 31, 5:31 PM
F15459878: D18126.id43617.diff
Mon, Mar 31, 5:31 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP887bd2d66ef0: In the UI, rename "Hide Inline" to "Collapse Inline"
Summary

Ref T12733. This paves the way for a separate "hide" operation which completely hides things.

(I didn't extend this to the server side because that would require schema changes and the new "hide" state is client-only.)

Test Plan

Collapsed and expanded inlines, viewed tooltips.

Diff Detail

Repository
rP Phabricator
Branch
menu1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17509
Build 23483: Run Core Tests
Build 23482: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 15 2017, 11:19 AM
Harbormaster completed remote builds in B17509: Diff 43617.Jun 15 2017, 11:20 AM
chad accepted this revision.Jun 15 2017, 12:17 PM
This revision is now accepted and ready to land.Jun 15 2017, 12:17 PM
Closed by commit rP887bd2d66ef0: In the UI, rename "Hide Inline" to "Collapse Inline" (authored by epriestley, committed by epriestley). · Explain WhyJun 15 2017, 12:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
50 lines
src/
applications/
differential/
view/
12 lines
infrastructure/
diff/
view/
2 lines
2 lines
webroot/
rsrc/
js/
application/
diff/
2 lines
46 lines
25 lines

Diff 43617

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetListView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffRevealIconView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility