Page MenuHomePhabricator

Add a retroactive migration to expand the `contentHash` field
ClosedPublic

Authored by epriestley on Jun 8 2017, 2:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 4:56 PM
Unknown Object (File)
Mon, Dec 2, 4:00 AM
Unknown Object (File)
Fri, Nov 29, 9:23 PM
Unknown Object (File)
Fri, Nov 29, 10:57 AM
Unknown Object (File)
Mon, Nov 25, 8:50 PM
Unknown Object (File)
Fri, Nov 22, 6:05 AM
Unknown Object (File)
Mon, Nov 18, 1:42 AM
Unknown Object (File)
Thu, Nov 14, 1:28 PM
Subscribers

Details

Summary

See D18037. The migration there may cause us to write new file records as a side effect.

Ideally, we would rewrite that migration to not ever have this kind of side effect. However, that would make it much more complicated, and it's already very complicated.

Instead, retroactively expand the size of this field before storage adjust does it, so it has the right size by the time we hit the migration in D18037.

Test Plan

@chad, can you arc patch this and see if it works?

It's possible that it will get us about five lines deeper and then we'll just hit another similar exception, and that this isn't really a viable way forward.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Gimmie a second, this is 100% wrong right now.

  • Use the correct column type.
  • Use the correct SQL syntax.
amckinley added a subscriber: amckinley.

Assuming I correctly understand all the discussion in D18037, this looks good to me.

This revision is now accepted and ready to land.Jun 8 2017, 2:18 PM

Alright, let's see how far we get with this.

This revision was automatically updated to reflect the committed changes.