Differential D18105
Write patterns to "git grep" on stdin instead of passing them with "-e" Authored by epriestley on Jun 8 2017, 12:56 PM. Tags None Referenced Files
Subscribers None
Details Fixes T12807. Some shells may apparently mangle/strip UTF8 characters? Just dodge this whole problem by sending the pattern over stdin rather than actually figuring out the particulars. Related tasks, like T7339 and T5554, discuss finding broader fixes for this class of issue, and this definitely isn't exactly a fully legitimate fix, but in many cases (as here) we can reasonably just avoid the problem rather than actually fixing it, at least for a long time. Searched for emoji and non-emoji locally, but this worked fine (on OSX) for me before the patch too.
Diff Detail
Event TimelineComment Actions For completeness, T13060 eventually got to the bottom of this: if the parent process has LANG=POSIX or similar, it can not encode UTF8 characters into subprocess command lines without changing the locale setting first. |