Paths

Table of Contentst

Differential D18065

Clean up some PHUI/PHUIX button behaviors
ClosedPublic
Actions

Authored by epriestley on Jun 2 2017, 11:12 AM.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12733: (2017 Week 20) Inline Comments Errata / Feedback

Commits

rPd42d69aef699: Clean up some PHUI/PHUIX button behaviors

Summary

Ref T12733. Some minor issues:

The strlen(...) test against $this->text fails if a caller does something like setText(array(...)). This is rare, but used in DiffusionBrowseController, from D15487.
Add PHUIX examples for icon-only buttons.
Remove unused SIMPLE constant now that no callsites remain.

Test Plan

Viewed a directory in Diffusion's "Browse" view in a Git repository, no longer saw a warning / error log.
Viewed PHUIX Components UI examples.
Grepped for ::SIMPLE.

Diff Detail

Repository

Branch

button1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17364
Build 23276: Run Core Tests
Build 23275: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 2 2017, 11:12 AM

Harbormaster completed remote builds in B17364: Diff 43451.Jun 2 2017, 11:13 AM

Screen Shot 2017-06-02 at 4.14.31 AM.png (1×1 px, 125 KB)

chad accepted this revision.Jun 2 2017, 1:43 PM

This revision is now accepted and ready to land.Jun 2 2017, 1:43 PM

Closed by commit rPd42d69aef699: Clean up some PHUI/PHUIX button behaviors (authored by epriestley, committed by epriestley). · Explain WhyJun 2 2017, 3:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

uiexample/

examples/

PHUIXComponentsExample.php

17 lines

view/

phui/

PHUIButtonView.php

5 lines

Diff 43451

src/applications/uiexample/examples/PHUIXComponentsExample.php

Loading...

src/view/phui/PHUIButtonView.php

Loading...