Page MenuHomePhabricator
Differential D18065

Clean up some PHUI/PHUIX button behaviors
ClosedPublic
Actions

Authored by epriestley on Jun 2 2017, 11:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 21, 6:41 PM
Unknown Object (File)
Fri, Feb 21, 3:21 AM
Unknown Object (File)
Thu, Feb 20, 11:39 PM
Unknown Object (File)
Tue, Feb 18, 10:35 PM
Unknown Object (File)
Feb 12 2025, 11:01 PM
Unknown Object (File)
Jan 31 2025, 8:25 AM
Unknown Object (File)
Jan 23 2025, 11:06 PM
Unknown Object (File)
Jan 23 2025, 8:45 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rPd42d69aef699: Clean up some PHUI/PHUIX button behaviors
Summary

Ref T12733. Some minor issues:

  • The strlen(...) test against $this->text fails if a caller does something like setText(array(...)). This is rare, but used in DiffusionBrowseController, from D15487.
  • Add PHUIX examples for icon-only buttons.
  • Remove unused SIMPLE constant now that no callsites remain.
Test Plan
  • Viewed a directory in Diffusion's "Browse" view in a Git repository, no longer saw a warning / error log.
  • Viewed PHUIX Components UI examples.
  • Grepped for ::SIMPLE.

Diff Detail

Repository
rP Phabricator
Branch
button1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17364
Build 23276: Run Core Tests
Build 23275: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
uiexample/
examples/
17 lines
view/
phui/
5 lines

Diff 43451

View Options

src/applications/uiexample/examples/PHUIXComponentsExample.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
Phabricator · Built by Phacility