Page MenuHomePhabricator
Differential D18061

Revert some changes to Diffusion History List
ClosedPublic
Actions

Authored by chad on Jun 1 2017, 7:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 11:42 AM
Unknown Object (File)
Thu, Dec 12, 4:10 AM
Unknown Object (File)
Wed, Dec 11, 5:42 AM
Unknown Object (File)
Sat, Dec 7, 7:41 AM
Unknown Object (File)
Thu, Dec 5, 1:31 AM
Unknown Object (File)
Tue, Dec 3, 10:51 AM
Unknown Object (File)
Thu, Nov 28, 11:12 PM
Unknown Object (File)
Mon, Nov 25, 1:26 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP0d8aba855021: Revert some changes to Diffusion History List
Summary

Ref rPf2fcafb40dde94ddf4ee22716fea74fca0334a64#38208, I think this is a more usable layout. Gets rid of clippy, audit. Adds back Differential link as tag, Build Status as button.

Test Plan

Faked data on this for Differential, Builds, should all work though. Test on real and fake repositories.

Diff Detail

Repository
rP Phabricator
Branch
history-page-v4 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17352
Build 23257: Run Core Tests
Build 23256: arc lint + arc unit

Event Timeline

chad created this revision.Jun 1 2017, 7:30 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJun 1 2017, 7:30 PM
Harbormaster completed remote builds in B17352: Diff 43439.Jun 1 2017, 7:32 PM
chad updated this revision to Diff 43441.Jun 1 2017, 7:33 PM
  • left in faked data
epriestley accepted this revision.Jun 1 2017, 7:34 PM
This revision is now accepted and ready to land.Jun 1 2017, 7:34 PM
Harbormaster completed remote builds in B17354: Diff 43441.Jun 1 2017, 7:35 PM
chad added inline comments.Jun 1 2017, 7:35 PM
webroot/rsrc/css/phui/phui-button.css
109–124

I'm going to clean up button state of the world in next few days, the CSS is getting hairy.

chad updated this revision to Diff 43442.Jun 1 2017, 7:37 PM
  • remove unused buildable code
Harbormaster completed remote builds in B17355: Diff 43442.Jun 1 2017, 7:38 PM
Closed by commit rP0d8aba855021: Revert some changes to Diffusion History List (authored by chad, committed by chad). · Explain WhyJun 1 2017, 7:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
diffusion/
view/
85 lines
webroot/
rsrc/
css/
application/
diffusion/
9 lines
phui/
32 lines

Diff 43439

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryListView.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-history.css

Loading...
View Options

webroot/rsrc/css/phui/phui-button.css

Loading...
Phabricator · Built by Phacility