Paths

Table of Contentst

Differential D18058

Hide "X created Y, a subtask of P." feed stories again
ClosedPublic
Actions

Authored by epriestley on Jun 1 2017, 2:59 PM.

Details

Reviewers

chad

Maniphest Tasks

T12787: Creating a subtask 'reopens' the new task

Commits

rP995c1503e7ef: Hide "X created Y, a subtask of P." feed stories again

Summary

Fixes T12787. Modular Transactions don't actually support shouldHideForFeed(). I'll add some discussion to the task.

Test Plan

Created a subtask, saw no more "X reopened Y, a subtask of P" feed story.

Diff Detail

Repository

rP Phabricator

Branch

sub1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17347
Build 23249: Run Core Tests
Build 23248: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 1 2017, 2:59 PM

Harbormaster completed remote builds in B17347: Diff 43434.Jun 1 2017, 3:00 PM

Thx

This revision is now accepted and ready to land.Jun 1 2017, 3:04 PM

Closed by commit rP995c1503e7ef: Hide "X created Y, a subtask of P." feed stories again (authored by epriestley, committed by epriestley). · Explain WhyJun 1 2017, 3:08 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12787: Creating a subtask 'reopens' the new task.Jun 1 2017, 3:14 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

storage/

ManiphestTransaction.php

16 lines

xaction/

ManiphestTaskUnblockTransaction.php

9 lines

Diff 43434

View Options

src/applications/maniphest/storage/ManiphestTransaction.php