Restrict green button to buttons
ClosedPublic
Actions

Authored by chad on May 31 2017, 4:44 AM.

Tags

None

Referenced Files

	F13148087: D18055.diff
	Fri, May 3, 8:43 PM

	F13144404: D18055.diff
	Fri, May 3, 8:09 AM

	Unknown Object (File)
	Thu, Apr 25, 2:10 AM

	Unknown Object (File)
	Mon, Apr 22, 6:19 AM

	Unknown Object (File)
	Thu, Apr 11, 9:37 AM

	Unknown Object (File)
	Apr 3 2024, 3:23 PM

	Unknown Object (File)
	Mar 31 2024, 2:13 PM

	Unknown Object (File)
	Mar 24 2024, 8:34 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12780: Icons look bad in HistoryTableView

Commits

rPf8581f687c9b: Restrict green button to buttons

Summary

Ref T12780. Button styles are bleeding over here on the icon, restrict to .button classes

Test Plan

uiexamples.

Diff Detail

Repository

rP Phabricator

Branch

green (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17339
Build 23237: Run Core Tests
Build 23236: arc lint + arc unit

Event Timeline

chad created this revision.May 31 2017, 4:44 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 31 2017, 4:44 AM

Harbormaster completed remote builds in B17339: Diff 43426.May 31 2017, 4:45 AM

epriestley accepted this revision.May 31 2017, 5:01 PM

This revision is now accepted and ready to land.May 31 2017, 5:01 PM

Closed by commit rPf8581f687c9b: Restrict green button to buttons (authored by chad, committed by chad). · Explain WhyMay 31 2017, 5:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-button.css

4 lines

Diff 43426

View Options

resources/celerity/map.php