Page MenuHomePhabricator

Use a list view for DiffusionHistory
ClosedPublic

Authored by chad on May 28 2017, 12:56 AM.
Tags
None
Referenced Files
F14077306: D18039.diff
Thu, Nov 21, 10:40 PM
Unknown Object (File)
Sep 5 2024, 12:07 AM
Unknown Object (File)
Sep 1 2024, 8:23 PM
Unknown Object (File)
Aug 31 2024, 9:30 PM
Unknown Object (File)
Aug 25 2024, 2:00 AM
Unknown Object (File)
Aug 24 2024, 11:24 AM
Unknown Object (File)
Aug 16 2024, 8:10 PM
Unknown Object (File)
Jul 31 2024, 4:45 AM
Subscribers

Details

Summary

This moves Diffusion History to use an easier to parse list view for commits and their (diff, audit, build) status. I left TableView around, which is used on a repositories home, and we can maybe add a "graph view" history back as another controller. Not sure what the real use is for that kind of feature though. I don't have Harbormaster set up locally so I could use another install to give this a run. I also expect to maybe not live with this UI as final, I like the UX, but the icons for indicating status don't really feel great to me, just OK.

Test Plan

pull various repositories, check various history displays.

image.png (1×1 px, 392 KB)

Diff Detail

Repository
rP Phabricator
Branch
diffusion-history-list (branched from master)
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/view/DiffusionHistoryView.php:31XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 17302
Build 23179: Run Core Tests
Build 23178: arc lint + arc unit

Event Timeline

webroot/rsrc/css/application/diffusion/diffusion-history.css
28

o.O

This revision is now accepted and ready to land.May 30 2017, 11:55 PM
This revision was automatically updated to reflect the committed changes.