Add needActiveDiffs to differential.createcomment method
ClosedPublic
Actions

Authored by chad on May 27 2017, 1:56 AM.

Tags

None

Referenced Files

	F15489323: D18038.id43386.diff
	Fri, Apr 11, 7:56 AM

	F15488836: D18038.id43385.diff
	Fri, Apr 11, 3:18 AM

	F15487315: D18038.id.diff
	Thu, Apr 10, 1:07 PM

	F15485046: D18038.diff
	Wed, Apr 9, 9:27 PM

	F15464854: D18038.id43385.diff
	Wed, Apr 2, 12:55 PM

	F15456980: D18038.id.diff
	Sun, Mar 30, 1:27 PM

	F15441902: D18038.id43385.diff
	Wed, Mar 26, 8:33 PM

	F15420549: D18038.id43386.diff
	Fri, Mar 21, 2:53 PM

View All Files

Subscribers

Korvin

reed

Details

Reviewers

epriestley
amckinley

Maniphest Tasks

T12766: Can't use `differential.createcomment` with message and action

Commits

rPe632db4fc0e9: (stable) Add needActiveDiffs to differential.createcomment method
rP3fb4ca2429b7: Add needActiveDiffs to differential.createcomment method

Summary

Ref T12766. Adds missing attachment for stacking actions in differential

Test Plan

Asked end user to verify patch.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 27 2017, 1:56 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 27 2017, 1:56 AM

reed added a subscriber: reed.May 27 2017, 1:56 AM

Harbormaster completed remote builds in B17297: Diff 43385.May 27 2017, 1:57 AM

ohkay

This revision is now accepted and ready to land.May 27 2017, 2:50 AM

chad requested review of this revision.May 27 2017, 2:51 AM

chad edited edge metadata.

epriestley accepted this revision.May 27 2017, 3:11 AM

This revision is now accepted and ready to land.May 27 2017, 3:11 AM

oh i requested review? im hiiiiiigh

Closed by commit rP3fb4ca2429b7: Add needActiveDiffs to differential.createcomment method (authored by chad, committed by chad). · Explain WhyMay 27 2017, 3:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

conduit/

DifferentialCreateCommentConduitAPIMethod.php

1 line

Diff 43386

View Options

src/applications/differential/conduit/DifferentialCreateCommentConduitAPIMethod.php

Add needActiveDiffs to differential.createcomment methodClosedPublicActions