Add ImageHref attribute for PHUIObjectItemListView
ClosedPublic
Actions

Authored by chad on May 24 2017, 11:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 30, 10:53 AM

	Unknown Object (File)
	Tue, Jan 28, 10:41 PM

	Unknown Object (File)
	Fri, Jan 24, 9:18 PM

	Unknown Object (File)
	Fri, Jan 24, 9:18 PM

	Unknown Object (File)
	Fri, Jan 24, 9:18 PM

	Unknown Object (File)
	Fri, Jan 24, 9:18 PM

	Unknown Object (File)
	Fri, Jan 24, 9:18 PM

	Unknown Object (File)
	Sun, Jan 19, 10:24 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP7cfa8a831535: Add ImageHref attribute for PHUIObjectItemListView

Summary

In some cases we may want a different URI for the image on an item than the header/title of the item (like user / title). This prioritizes ImageHref over Href.

Test Plan

uiexamples

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 24 2017, 11:51 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 24 2017, 11:51 PM

Harbormaster completed remote builds in B17243: Diff 43331.May 24 2017, 11:52 PM

Minor issues with "0" but that's probably not a valid link.

This revision is now accepted and ready to land.May 25 2017, 5:40 PM

I suppose that's pre-existing.

strlen

Harbormaster completed remote builds in B17246: Diff 43334.May 25 2017, 5:58 PM

Closed by commit rP7cfa8a831535: Add ImageHref attribute for PHUIObjectItemListView (authored by chad, committed by chad). · Explain WhyMay 25 2017, 5:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

uiexample/

examples/

PHUIObjectItemListExample.php

2 lines

view/

phui/

PHUIObjectItemView.php

11 lines

Diff 43335

View Options

src/applications/uiexample/examples/PHUIObjectItemListExample.php