Add ImageHref attribute for PHUIObjectItemListView
ClosedPublic
Actions

Authored by chad on May 24 2017, 11:51 PM.

Details

Reviewers

Commits

rP7cfa8a831535: Add ImageHref attribute for PHUIObjectItemListView

Summary

In some cases we may want a different URI for the image on an item than the header/title of the item (like user / title). This prioritizes ImageHref over Href.

Test Plan

uiexamples

Diff Detail

Repository

rP Phabricator

Branch

oi-href (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17243
Build 23088: Run Core Tests
Build 23087: arc lint + arc unit

Event Timeline

chad created this revision.May 24 2017, 11:51 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 24 2017, 11:51 PM

Harbormaster completed remote builds in B17243: Diff 43331.May 24 2017, 11:52 PM

Minor issues with "0" but that's probably not a valid link.

This revision is now accepted and ready to land.May 25 2017, 5:40 PM

I suppose that's pre-existing.

strlen

Harbormaster completed remote builds in B17246: Diff 43334.May 25 2017, 5:58 PM

Closed by commit rP7cfa8a831535: Add ImageHref attribute for PHUIObjectItemListView (authored by chad, committed by chad). · Explain WhyMay 25 2017, 5:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

uiexample/

examples/

PHUIObjectItemListExample.php

2 lines

view/

phui/

PHUIObjectItemView.php

11 lines

Diff 43331

View Options

src/applications/uiexample/examples/PHUIObjectItemListExample.php