Page MenuHomePhabricator
Differential D18014

Migrate Project workboard background color to modular transactions
ClosedPublic
Actions

Authored by amckinley on May 24 2017, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 2:19 PM
Unknown Object (File)
Sun, Apr 7, 12:48 AM
Unknown Object (File)
Sat, Apr 6, 11:58 PM
Unknown Object (File)
Sat, Apr 6, 10:51 PM
Unknown Object (File)
Sat, Apr 6, 9:59 PM
Unknown Object (File)
Sat, Apr 6, 9:41 PM
Unknown Object (File)
Mon, Apr 1, 9:10 PM
Unknown Object (File)
Sun, Mar 31, 11:34 PM
View All Files
Subscribers
epriestley

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T12673: Update Projects for Modular Transactions
Commits
rP88466addee26: Migrate Project workboard background color to modular transactions
Summary

Removes now-unused method as well. Fixes T12673.

Test Plan

UI fiddling.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley created this revision.May 24 2017, 7:54 PM
Herald added a subscriber: epriestley. · View Herald TranscriptMay 24 2017, 7:54 PM
epriestley accepted this revision.May 24 2017, 7:54 PM

v. nice

This revision is now accepted and ready to land.May 24 2017, 7:54 PM
Harbormaster completed remote builds in B17239: Diff 43327.May 24 2017, 7:55 PM
amckinley added inline comments.May 24 2017, 7:55 PM
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
56–60

I'm pretty sure (and a quick test seemed to confirm) that this code isn't needed with the way modular transactions work.

Closed by commit rP88466addee26: Migrate Project workboard background color to modular transactions (authored by amckinley, committed by amckinley). · Explain WhyMay 24 2017, 7:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43328

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...
View Options

src/applications/project/xaction/PhabricatorProjectWorkboardBackgroundTransaction.php

Loading...
Phabricator · Built by Phacility