Gives the ability to hide a big long block of text in an ObjectListItem without cluttering the UI.
Details
Details
- Reviewers
epriestley - Commits
- rP684ce701fb03: Add a description/toggle to PHUIObjectItemView
Added a test case to UIExamples. Click on icon, see content. Click again, content go away.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- object-item-description (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17221 Build 23054: Run Core Tests Build 23053: arc lint + arc unit
Event Timeline
| src/applications/diffusion/view/DiffusionHistoryListView.php | ||
|---|---|---|
| 109 | Since this isn't batched, I'd expect it to be quite slow in the general case (e.g., if we show 100 commits and they each mention revisions/users, we'll do 100+ single queries), but we can deal with that later. | |
Comment Actions
(There isn't a very good "right" way to do it right now and I'd like to move us to something like HandlePool since I think that has been successful in making it a lot less cumbersome to do fetches with handles efficiently.)