Page MenuHomePhabricator
Differential D18006

Add a description/toggle to PHUIObjectItemView
ClosedPublic
Actions

Authored by chad on May 23 2017, 11:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 14, 1:26 PM
Unknown Object (File)
Sun, May 11, 3:52 PM
Unknown Object (File)
Tue, May 6, 12:34 PM
Unknown Object (File)
Apr 29 2025, 5:32 AM
Unknown Object (File)
Apr 27 2025, 7:03 PM
Unknown Object (File)
Apr 26 2025, 3:43 AM
Unknown Object (File)
Apr 25 2025, 12:11 PM
Unknown Object (File)
Apr 14 2025, 10:45 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP684ce701fb03: Add a description/toggle to PHUIObjectItemView
Summary

Gives the ability to hide a big long block of text in an ObjectListItem without cluttering the UI.

Test Plan

Added a test case to UIExamples. Click on icon, see content. Click again, content go away.

image.png (386×594 px, 31 KB)

image.png (974×2 px, 208 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.May 23 2017, 11:44 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 23 2017, 11:44 PM
Harbormaster completed remote builds in B17220: Diff 43308.May 23 2017, 11:45 PM
chad edited the test plan for this revision. (Show Details)May 23 2017, 11:45 PM
chad updated this revision to Diff 43309.May 24 2017, 2:22 AM
  • use in DiffusionHistoryListView
chad edited the test plan for this revision. (Show Details)May 24 2017, 2:22 AM
Harbormaster completed remote builds in B17221: Diff 43309.May 24 2017, 2:23 AM
epriestley accepted this revision.May 24 2017, 1:34 PM
This revision is now accepted and ready to land.May 24 2017, 1:34 PM
epriestley added inline comments.May 24 2017, 1:36 PM
src/applications/diffusion/view/DiffusionHistoryListView.php
109

Since this isn't batched, I'd expect it to be quite slow in the general case (e.g., if we show 100 commits and they each mention revisions/users, we'll do 100+ single queries), but we can deal with that later.

epriestley added a comment.May 24 2017, 1:38 PM

(There isn't a very good "right" way to do it right now and I'd like to move us to something like HandlePool since I think that has been successful in making it a lot less cumbersome to do fetches with handles efficiently.)

chad added a comment.May 24 2017, 4:17 PM

hmmmmmm, ok, should I file something?

Closed by commit rP684ce701fb03: Add a description/toggle to PHUIObjectItemView (authored by chad, committed by chad). · Explain WhyMay 24 2017, 4:18 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.May 24 2017, 4:30 PM

Sure, couldn't hurt if you want to jot it down.

chad mentioned this in T12749: Performance test and tune DiffusionHistoryListView.May 24 2017, 5:09 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
diffusion/
view/
9 lines
uiexample/
examples/
2 lines
view/
phui/
34 lines
webroot/
rsrc/
css/
application/
diffusion/
8 lines
phui/
object-item/
25 lines

Diff 43313

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/view/DiffusionHistoryListView.php

Loading...
View Options

src/applications/uiexample/examples/PHUIObjectItemListExample.php

Loading...
View Options

src/view/phui/PHUIObjectItemView.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-history.css

Loading...
View Options

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...
Phabricator · Built by Phacility