Page MenuHomePhabricator

Add a description/toggle to PHUIObjectItemView
ClosedPublic

Authored by chad on May 23 2017, 11:44 PM.
Tags
None
Referenced Files
F19939118: D18006.diff
Tue, Apr 14, 9:48 AM
F19673264: D18006.id43308.diff
Feb 8 2026, 5:30 AM
F19673263: D18006.id43308.diff
Feb 8 2026, 5:30 AM
F19626213: D18006.id43309.diff
Feb 4 2026, 7:28 PM
F18994011: D18006.id43309.diff
Nov 19 2025, 9:37 AM
F18993792: D18006.diff
Nov 19 2025, 8:37 AM
F18941641: D18006.id43308.diff
Nov 11 2025, 10:47 AM
F18807755: D18006.id.diff
Oct 19 2025, 3:24 AM
Subscribers

Details

Summary

Gives the ability to hide a big long block of text in an ObjectListItem without cluttering the UI.

Test Plan

Added a test case to UIExamples. Click on icon, see content. Click again, content go away.

image.png (386×594 px, 31 KB)

image.png (974×2 px, 208 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • use in DiffusionHistoryListView
This revision is now accepted and ready to land.May 24 2017, 1:34 PM
src/applications/diffusion/view/DiffusionHistoryListView.php
109

Since this isn't batched, I'd expect it to be quite slow in the general case (e.g., if we show 100 commits and they each mention revisions/users, we'll do 100+ single queries), but we can deal with that later.

(There isn't a very good "right" way to do it right now and I'd like to move us to something like HandlePool since I think that has been successful in making it a lot less cumbersome to do fetches with handles efficiently.)

hmmmmmm, ok, should I file something?

This revision was automatically updated to reflect the committed changes.

Sure, couldn't hurt if you want to jot it down.