Paths

Table of Contentst

Differential D18006

Add a description/toggle to PHUIObjectItemView
ClosedPublic
Actions

Authored by chad on May 23 2017, 11:44 PM.

Tags

None

Referenced Files

	F15459059: D18006.id.diff
	Mon, Mar 31, 9:29 AM

	F15456397: D18006.diff
	Sun, Mar 30, 9:26 AM

	F15427298: D18006.id43308.diff
	Sun, Mar 23, 1:36 PM

	F15390232: D18006.id43309.diff
	Mar 15 2025, 6:02 AM

	F15379490: D18006.id43309.diff
	Mar 13 2025, 9:29 PM

	F15371247: D18006.id43313.diff
	Mar 12 2025, 11:59 AM

	Unknown Object (File)
	Feb 15 2025, 4:23 PM

	Unknown Object (File)
	Feb 9 2025, 4:12 AM

Subscribers

Details

Reviewers

Commits

rP684ce701fb03: Add a description/toggle to PHUIObjectItemView

Summary

Gives the ability to hide a big long block of text in an ObjectListItem without cluttering the UI.

Test Plan

Added a test case to UIExamples. Click on icon, see content. Click again, content go away.

image.png (386×594 px, 31 KB)

image.png (974×2 px, 208 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 23 2017, 11:44 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 23 2017, 11:44 PM

Harbormaster completed remote builds in B17220: Diff 43308.May 23 2017, 11:45 PM

chad edited the test plan for this revision. (Show Details)May 23 2017, 11:45 PM

use in DiffusionHistoryListView

chad edited the test plan for this revision. (Show Details)May 24 2017, 2:22 AM

Harbormaster completed remote builds in B17221: Diff 43309.May 24 2017, 2:23 AM

epriestley accepted this revision.May 24 2017, 1:34 PM

This revision is now accepted and ready to land.May 24 2017, 1:34 PM

epriestley added inline comments.May 24 2017, 1:36 PM

src/applications/diffusion/view/DiffusionHistoryListView.php
109	Since this isn't batched, I'd expect it to be quite slow in the general case (e.g., if we show 100 commits and they each mention revisions/users, we'll do 100+ single queries), but we can deal with that later.

(There isn't a very good "right" way to do it right now and I'd like to move us to something like HandlePool since I think that has been successful in making it a lot less cumbersome to do fetches with handles efficiently.)

hmmmmmm, ok, should I file something?

Closed by commit rP684ce701fb03: Add a description/toggle to PHUIObjectItemView (authored by chad, committed by chad). · Explain WhyMay 24 2017, 4:18 PM

This revision was automatically updated to reflect the committed changes.

Sure, couldn't hurt if you want to jot it down.

chad mentioned this in T12749: Performance test and tune DiffusionHistoryListView.May 24 2017, 5:09 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

10 lines

src/

applications/

diffusion/

view/

DiffusionHistoryListView.php

9 lines

uiexample/

examples/

PHUIObjectItemListExample.php

2 lines

view/

phui/

PHUIObjectItemView.php

34 lines

webroot/

rsrc/

css/

application/

diffusion/

diffusion-history.css

8 lines

phui/

object-item/

phui-oi-list-view.css

25 lines

Diff 43313

resources/celerity/map.php

Loading...

src/applications/diffusion/view/DiffusionHistoryListView.php

Loading...

src/applications/uiexample/examples/PHUIObjectItemListExample.php

Loading...

src/view/phui/PHUIObjectItemView.php

Loading...

webroot/rsrc/css/application/diffusion/diffusion-history.css

Loading...

webroot/rsrc/css/phui/object-item/phui-oi-list-view.css

Loading...