Page MenuHomePhabricator

Update PhrictionContent for modular transactions
ClosedPublic

Authored by chad on May 23 2017, 3:13 AM.

Details

Summary

Fixes T12625. Moves TYPE_CONTENT in Phriction over to modular transactions.

Test Plan

Edit some documents.

Diff Detail

Repository
rP Phabricator
Branch
phriction-content-txn (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17203
Build 23025: Run Core Tests
Build 23024: arc lint + arc unit

Event Timeline

Confused about one thing, see inline?

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
12–25

Why is this OK to remove / being removed?

Also, congratulations on desirable round-numbered change D18000!

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
12–25

whoops

Also I can't seem to trigger "CHANGES TO DOCUMENT CONTENT" into mail, any ideas?

Seems to work for me, maybe daemons just need to be restarted to pick up changes?

Screen Shot 2017-05-23 at 11.42.58 AM.png (710×1 px, 86 KB)

This revision is now accepted and ready to land.May 23 2017, 7:01 PM
This revision was automatically updated to reflect the committed changes.