Page MenuHomePhabricator
Differential D17981

Show "reply" inlines as replies in the objective list
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 12:51 PM.
Tags
None
Referenced Files
F13132319: D17981.diff
Wed, May 1, 6:48 PM
F13128385: D17981.diff
Tue, Apr 30, 11:39 PM
Unknown Object (File)
Fri, Apr 19, 6:31 PM
Unknown Object (File)
Sun, Apr 14, 9:23 AM
Unknown Object (File)
Sun, Apr 14, 2:47 AM
Unknown Object (File)
Sat, Apr 13, 4:08 PM
Unknown Object (File)
Sat, Apr 13, 12:11 PM
Unknown Object (File)
Sat, Apr 13, 5:37 AM
View All 95 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rPe6843b1c00f3: (stable) Show "reply" inlines as replies in the objective list
rPe15009b76e1b: Show "reply" inlines as replies in the objective list
Summary

Ref T12733. Show a "reply" icon for replies, and make them stack directly under their parent.

Test Plan

Screen Shot 2017-05-20 at 5.49.02 AM.png (109×134 px, 5 KB)

Diff Detail

Repository
rP Phabricator
Branch
map8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17146
Build 22946: Run Core Tests
Build 22945: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2017, 12:51 PM
Harbormaster completed remote builds in B17146: Diff 43238.May 20 2017, 12:52 PM
chad accepted this revision.May 20 2017, 2:34 PM
This revision is now accepted and ready to land.May 20 2017, 2:34 PM
Closed by commit rPe15009b76e1b: Show "reply" inlines as replies in the objective list (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2017, 3:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
52 lines
webroot/
rsrc/
js/
application/
diff/
5 lines
18 lines
9 lines

Diff 43238

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
View Options

webroot/rsrc/js/application/diff/ScrollObjective.js

Loading...
View Options

webroot/rsrc/js/application/diff/ScrollObjectiveList.js

Loading...
Phabricator · Built by Phacility