Page MenuHomePhabricator
Differential D17980

Show a snippet when hovering inlines in the objective list
ClosedPublic
Actions

Authored by epriestley on May 20 2017, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 8:47 PM
Unknown Object (File)
Sat, Nov 23, 4:09 AM
Unknown Object (File)
Sat, Nov 23, 12:33 AM
Unknown Object (File)
Oct 21 2024, 4:21 PM
Unknown Object (File)
Oct 21 2024, 2:51 AM
Unknown Object (File)
Oct 17 2024, 3:40 AM
Unknown Object (File)
Oct 13 2024, 4:40 PM
Unknown Object (File)
Sep 30 2024, 5:47 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12733: (2017 Week 20) Inline Comments Errata / Feedback
Commits
rP253f7b0bb9bd: (stable) Show a snippet when hovering inlines in the objective list
rP4dff754502bd: Show a snippet when hovering inlines in the objective list
Summary

Ref T12733. Shows a comment snippet when hovering inlines in the objective list.

Test Plan

Screen Shot 2017-05-20 at 5.38.47 AM.png (111×283 px, 9 KB)

Diff Detail

Repository
rP Phabricator
Branch
map7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17145
Build 22944: Run Core Tests
Build 22943: arc lint + arc unit

Event Timeline

epriestley created this revision.May 20 2017, 12:40 PM
Harbormaster completed remote builds in B17145: Diff 43237.May 20 2017, 12:41 PM
chad accepted this revision.May 20 2017, 2:34 PM
This revision is now accepted and ready to land.May 20 2017, 2:34 PM
Closed by commit rP4dff754502bd: Show a snippet when hovering inlines in the objective list (authored by epriestley, committed by epriestley). · Explain WhyMay 20 2017, 3:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
src/
infrastructure/
diff/
view/
9 lines
webroot/
rsrc/
js/
application/
diff/
4 lines

Diff 43237

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/js/application/diff/DiffInline.js

Loading...
Phabricator · Built by Phacility