Page MenuHomePhabricator

Hide the Differential scroll objective list on trackpad systems
ClosedPublic

Authored by epriestley on May 20 2017, 11:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 8:37 PM
Unknown Object (File)
Sat, Nov 16, 5:09 PM
Unknown Object (File)
Thu, Nov 14, 7:35 PM
Unknown Object (File)
Oct 17 2024, 3:39 AM
Unknown Object (File)
Oct 1 2024, 7:25 PM
Unknown Object (File)
Sep 22 2024, 7:55 AM
Unknown Object (File)
Sep 10 2024, 12:46 AM
Unknown Object (File)
Sep 8 2024, 3:27 PM
Subscribers
None

Details

Summary

Ref T12733. In the longer run I'd like to just push this out from the edge, but that currently gets us into trouble since we start bumping into content. On my system, the trackpad scrollbar also expands in size when moused over, so the minimum number of pixels we need to push it out is approximatley 15px. This hits body content and the persistent chat.

For now, just disable this element on trackpad systems.

Test Plan

Disconnected all USB peripherals, quit and relaunched Safari, saw no objective list.

Reconnected mouse, relaunched Safari, saw objective list.

Diff Detail

Repository
rP Phabricator
Branch
map1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17139
Build 22932: Run Core Tests
Build 22931: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.May 20 2017, 1:51 PM
This revision was automatically updated to reflect the committed changes.