Fix Phriction status not set property on new document
ClosedPublic
Actions

Authored by chad on May 19 2017, 4:25 PM.

Details

Reviewers

Commits

rPd783299a19c5: Fix Phriction status not set property on new document

Summary

I deleted too many lines of code here and TYPE_MOVE was always being applied when CONTENT was set. This should fix on next document save, but should I write some migration tool anyways?

Test Plan

Create a new document, see document with correct status.

Diff Detail

Repository

rP Phabricator

Branch

phriction-title-transaction (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17107
Build 22886: Run Core Tests
Build 22885: arc lint + arc unit

Event Timeline

chad created this revision.May 19 2017, 4:25 PM

Harbormaster completed remote builds in B17107: Diff 43196.May 19 2017, 4:25 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 19 2017, 4:25 PM

Harbormaster completed remote builds in B17107: Diff 43196.May 19 2017, 4:26 PM

chad added inline comments.May 19 2017, 4:29 PM

src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php
17–19	Seems to work in either place, but this was missed during conversion.

epriestley accepted this revision.May 19 2017, 5:56 PM

This revision is now accepted and ready to land.May 19 2017, 5:56 PM

Closed by commit rPd783299a19c5: Fix Phriction status not set property on new document (authored by chad, committed by chad). · Explain WhyMay 19 2017, 5:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

editor/

PhrictionTransactionEditor.php

4 lines

xaction/

PhrictionDocumentTitleTransaction.php

3 lines

Diff 43196

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php