Page MenuHomePhabricator

Fix Phriction status not set property on new document
ClosedPublic

Authored by chad on May 19 2017, 4:25 PM.
Tags
None
Referenced Files
F13456929: D17960.diff
Sun, Jul 14, 4:21 PM
F13448365: D17960.id.diff
Sat, Jul 13, 4:55 AM
F13434074: D17960.id43196.diff
Wed, Jul 10, 7:58 PM
F13383785: D17960.id43200.diff
Sun, Jun 30, 1:03 PM
F13381589: D17960.diff
Sun, Jun 30, 2:14 AM
F13363803: D17960.diff
Wed, Jun 26, 4:55 AM
F13363802: D17960.diff
Wed, Jun 26, 4:55 AM
F13355343: D17960.id43200.diff
Mon, Jun 24, 10:57 AM
Subscribers

Details

Summary

I deleted too many lines of code here and TYPE_MOVE was always being applied when CONTENT was set. This should fix on next document save, but should I write some migration tool anyways?

Test Plan

Create a new document, see document with correct status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php
17–19

Seems to work in either place, but this was missed during conversion.

This revision is now accepted and ready to land.May 19 2017, 5:56 PM
This revision was automatically updated to reflect the committed changes.