Page MenuHomePhabricator

Fix Phriction status not set property on new document
ClosedPublic

Authored by chad on May 19 2017, 4:25 PM.
Tags
None
Referenced Files
F17899427: D17960.id43200.diff
Tue, Jul 29, 8:38 AM
F17876346: D17960.diff
Mon, Jul 28, 7:01 PM
F17876320: D17960.diff
Mon, Jul 28, 7:00 PM
F17850946: D17960.id.diff
Sun, Jul 27, 10:40 AM
F17842959: D17960.diff
Sun, Jul 27, 12:18 AM
Unknown Object (File)
Jun 1 2025, 10:28 PM
Unknown Object (File)
May 21 2025, 12:14 AM
Unknown Object (File)
May 11 2025, 6:20 PM
Subscribers

Details

Summary

I deleted too many lines of code here and TYPE_MOVE was always being applied when CONTENT was set. This should fix on next document save, but should I write some migration tool anyways?

Test Plan

Create a new document, see document with correct status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php
17–19

Seems to work in either place, but this was missed during conversion.

This revision is now accepted and ready to land.May 19 2017, 5:56 PM
This revision was automatically updated to reflect the committed changes.