Page MenuHomePhabricator

Fix Phriction status not set property on new document
ClosedPublic

Authored by chad on May 19 2017, 4:25 PM.
Tags
None
Referenced Files
F15502835: D17960.id43196.diff
Mon, Apr 14, 4:45 AM
F15474061: D17960.diff
Sun, Apr 6, 5:02 AM
F15441931: D17960.diff
Wed, Mar 26, 8:39 PM
F15373198: D17960.diff
Mar 12 2025, 3:01 PM
Unknown Object (File)
Feb 27 2025, 3:34 AM
Unknown Object (File)
Feb 27 2025, 3:12 AM
Unknown Object (File)
Feb 25 2025, 11:27 PM
Unknown Object (File)
Feb 25 2025, 7:58 PM
Subscribers

Details

Summary

I deleted too many lines of code here and TYPE_MOVE was always being applied when CONTENT was set. This should fix on next document save, but should I write some migration tool anyways?

Test Plan

Create a new document, see document with correct status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php
17–19

Seems to work in either place, but this was missed during conversion.

This revision is now accepted and ready to land.May 19 2017, 5:56 PM
This revision was automatically updated to reflect the committed changes.