Page MenuHomePhabricator

Add Pinboard Items to Timeline
ClosedPublic

Authored by chad on May 18 2017, 5:25 PM.

Details

Summary

This allows adding of pinboard items to a timeline. I'm hoping we can get this in for Maniphest (Pholio, Cover Image) and Macro (because, Macro), but unsure how to scalably do this. Anyways, here's the front end.

Test Plan

Make some fake timeline items in UIExamples, test mobile, tablet, and desktop breakpoints.

image.png (1×2 px, 349 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Looks promising to me. I think we can make this work without too much hardship.

This revision is now accepted and ready to land.May 18 2017, 5:32 PM

Yeah I started to force something into transactions but realized it'd bite me in the end if it wasn't scalable. At least pinboard for image display should work in most/all cases and case be tweaked as needed (lightbox).

This revision was automatically updated to reflect the committed changes.